From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52D2BC433B4 for ; Wed, 19 May 2021 12:39:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2E6C160FE8 for ; Wed, 19 May 2021 12:39:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1353428AbhESMkg (ORCPT ); Wed, 19 May 2021 08:40:36 -0400 Received: from lpdvacalvio01.broadcom.com ([192.19.229.182]:33680 "EHLO relay.smtp-ext.broadcom.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1353419AbhESMkf (ORCPT ); Wed, 19 May 2021 08:40:35 -0400 Received: from bld-lvn-bcawlan-34.lvn.broadcom.net (bld-lvn-bcawlan-34.lvn.broadcom.net [10.75.138.137]) by relay.smtp-ext.broadcom.com (Postfix) with ESMTP id D722624706; Wed, 19 May 2021 05:39:15 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 relay.smtp-ext.broadcom.com D722624706 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com; s=dkimrelay; t=1621427955; bh=rmuK/K3fBffMGY9dTheEJuib9VCu9Gy25cLus+IJUug=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=VgS533qm3C1EqyRmsV7B0Xs4p19KcSWkZBffW6Cf6caYrMtmogkGbUjQEqgK1PVEt +jL87cedxnr6z/qWPoqa0LOepb56Zuy8L3Apu/OkLEy1ZMMpX0PlmDpbuGrfuHYcEQ elsFfUk4kEEG4P58APWaL33j8OpRbgJUTXNcmUr0= Received: from [10.230.42.155] (unknown [10.230.42.155]) by bld-lvn-bcawlan-34.lvn.broadcom.net (Postfix) with ESMTPSA id 6F0051874BE; Wed, 19 May 2021 05:39:11 -0700 (PDT) Subject: Re: [PATCH] brcmsmac: mac80211_if: Fix a resource leak in an error handling path To: Christophe JAILLET , aspriel@gmail.com, franky.lin@broadcom.com, hante.meuleman@broadcom.com, chi-hsien.lin@infineon.com, wright.feng@infineon.com, chung-hsien.hsu@infineon.com, davem@davemloft.net, kvalo@codeaurora.org, kuba@kernel.org Cc: linux-wireless@vger.kernel.org, brcm80211-dev-list.pdl@broadcom.com, SHA-cyfmac-dev-list@infineon.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org References: <8fbc171a1a493b38db5a6f0873c6021fca026a6c.1620852921.git.christophe.jaillet@wanadoo.fr> From: Arend van Spriel Message-ID: <3b96aa02-869c-4663-1c63-759d058b8744@broadcom.com> Date: Wed, 19 May 2021 14:39:08 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <8fbc171a1a493b38db5a6f0873c6021fca026a6c.1620852921.git.christophe.jaillet@wanadoo.fr> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: kernel-janitors@vger.kernel.org On 12-05-2021 22:58, Christophe JAILLET wrote: > If 'brcms_attach()' fails, we must undo the previous 'ieee80211_alloc_hw()' > as already done in the remove function. Acked-by: Arend van Spriel > Fixes: 5b435de0d786 ("net: wireless: add brcm80211 drivers") > Signed-off-by: Christophe JAILLET > --- > .../wireless/broadcom/brcm80211/brcmsmac/mac80211_if.c | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-)