* [PATCH] ocfs2/dlm: Remove redundant assignment of variable ret
@ 2021-10-07 23:34 Colin King
2021-10-08 3:43 ` Joseph Qi
0 siblings, 1 reply; 2+ messages in thread
From: Colin King @ 2021-10-07 23:34 UTC (permalink / raw)
To: Mark Fasheh, Joel Becker, Joseph Qi, ocfs2-devel
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
The variable ret is being assigned a value that is never read, it is
updated later on with a different value. The assignment is redundant and
can be removed.
Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
fs/ocfs2/dlm/dlmrecovery.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/fs/ocfs2/dlm/dlmrecovery.c b/fs/ocfs2/dlm/dlmrecovery.c
index e24e327524f8..52ad342fec3e 100644
--- a/fs/ocfs2/dlm/dlmrecovery.c
+++ b/fs/ocfs2/dlm/dlmrecovery.c
@@ -2698,7 +2698,6 @@ static int dlm_send_begin_reco_message(struct dlm_ctxt *dlm, u8 dead_node)
continue;
}
retry:
- ret = -EINVAL;
mlog(0, "attempting to send begin reco msg to %d\n",
nodenum);
ret = o2net_send_message(DLM_BEGIN_RECO_MSG, dlm->key,
--
2.32.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ocfs2/dlm: Remove redundant assignment of variable ret
2021-10-07 23:34 [PATCH] ocfs2/dlm: Remove redundant assignment of variable ret Colin King
@ 2021-10-08 3:43 ` Joseph Qi
0 siblings, 0 replies; 2+ messages in thread
From: Joseph Qi @ 2021-10-08 3:43 UTC (permalink / raw)
To: Colin King, akpm
Cc: kernel-janitors, linux-kernel, ocfs2-devel, Mark Fasheh, Joel Becker
On 10/8/21 7:34 AM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The variable ret is being assigned a value that is never read, it is
> updated later on with a different value. The assignment is redundant and
> can be removed.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Joseph Qi <joseph.qi@linux.alibaba.com>
> ---
> fs/ocfs2/dlm/dlmrecovery.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/fs/ocfs2/dlm/dlmrecovery.c b/fs/ocfs2/dlm/dlmrecovery.c
> index e24e327524f8..52ad342fec3e 100644
> --- a/fs/ocfs2/dlm/dlmrecovery.c
> +++ b/fs/ocfs2/dlm/dlmrecovery.c
> @@ -2698,7 +2698,6 @@ static int dlm_send_begin_reco_message(struct dlm_ctxt *dlm, u8 dead_node)
> continue;
> }
> retry:
> - ret = -EINVAL;
> mlog(0, "attempting to send begin reco msg to %d\n",
> nodenum);
> ret = o2net_send_message(DLM_BEGIN_RECO_MSG, dlm->key,
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-10-08 3:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-07 23:34 [PATCH] ocfs2/dlm: Remove redundant assignment of variable ret Colin King
2021-10-08 3:43 ` Joseph Qi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).