* Re: [PATCH] ASoC: fsl_mqs: Fix unchecked return value for clk_prepare_enable
@ 2020-06-22 16:07 Markus Elfring
2020-06-23 5:13 ` Shengjiu Wang
0 siblings, 1 reply; 2+ messages in thread
From: Markus Elfring @ 2020-06-22 16:07 UTC (permalink / raw)
To: Shengjiu Wang, alsa-devel, linuxppc-dev
Cc: Timur Tabi, Xiubo Li, Takashi Iwai, kernel-janitors,
linux-kernel, Nicolin Chen, Mark Brown, Fabio Estevam
> Fix unchecked return value for clk_prepare_enable.
>
> And because clk_prepare_enable and clk_disable_unprepare should
> check input clock parameter is NULL or not, then we don't need
> to check it before calling the function.
I propose to split the adjustment of two function implementations
into separate update steps for a small patch series.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?idb5d3449788f85569096780592549d0340e9c0c7#n138
I suggest to improve the change descriptions accordingly.
Regards,
Markus
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] ASoC: fsl_mqs: Fix unchecked return value for clk_prepare_enable
2020-06-22 16:07 [PATCH] ASoC: fsl_mqs: Fix unchecked return value for clk_prepare_enable Markus Elfring
@ 2020-06-23 5:13 ` Shengjiu Wang
0 siblings, 0 replies; 2+ messages in thread
From: Shengjiu Wang @ 2020-06-23 5:13 UTC (permalink / raw)
To: Markus Elfring
Cc: Linux-ALSA, Timur Tabi, Xiubo Li, Fabio Estevam, Shengjiu Wang,
kernel-janitors, Takashi Iwai, linux-kernel, Nicolin Chen,
Mark Brown, linuxppc-dev
On Tue, Jun 23, 2020 at 12:08 AM Markus Elfring <Markus.Elfring@web.de> wrote:
>
> > Fix unchecked return value for clk_prepare_enable.
> >
> > And because clk_prepare_enable and clk_disable_unprepare should
> > check input clock parameter is NULL or not, then we don't need
> > to check it before calling the function.
>
> I propose to split the adjustment of two function implementations
> into separate update steps for a small patch series.
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?idb5d3449788f85569096780592549d0340e9c0c7#n138
>
> I suggest to improve the change descriptions accordingly.
ok, will update the patches in v2.
best regards
wang shengjiu
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-06-23 5:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-22 16:07 [PATCH] ASoC: fsl_mqs: Fix unchecked return value for clk_prepare_enable Markus Elfring
2020-06-23 5:13 ` Shengjiu Wang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).