From mboxrd@z Thu Jan 1 00:00:00 1970 From: Markus Elfring Date: Mon, 22 Jun 2020 16:07:02 +0000 Subject: Re: [PATCH] ASoC: fsl_mqs: Fix unchecked return value for clk_prepare_enable Message-Id: <3eab889e-75b6-6287-a668-a2eaa509834c@web.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Shengjiu Wang , alsa-devel@alsa-project.org, linuxppc-dev@lists.ozlabs.org Cc: Timur Tabi , Xiubo Li , Takashi Iwai , kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, Nicolin Chen , Mark Brown , Fabio Estevam > Fix unchecked return value for clk_prepare_enable. > > And because clk_prepare_enable and clk_disable_unprepare should > check input clock parameter is NULL or not, then we don't need > to check it before calling the function. I propose to split the adjustment of two function implementations into separate update steps for a small patch series. https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?idb5d3449788f85569096780592549d0340e9c0c7#n138 I suggest to improve the change descriptions accordingly. Regards, Markus