From mboxrd@z Thu Jan 1 00:00:00 1970 From: Markus Elfring Date: Thu, 11 Jun 2020 08:40:17 +0000 Subject: Re: [PATCH v2] exfat: add missing brelse() calls on error paths Message-Id: <420560fd-51bf-2d17-7a49-ac56653ec779@web.de> List-Id: References: <20200610172213.GA90634@mwanda> In-Reply-To: <20200610172213.GA90634@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: Dan Carpenter , Namjae Jeon , Sungjong Seo , linux-fsdevel@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, =?UTF-8?Q?Pali_Roh=c3=a1r?= , Tetsuhiro Kohada , Wei Yongjun … > +++ b/fs/exfat/namei.c > @@ -1077,10 +1077,14 @@ static int exfat_rename_file(struct inode *inode, struct exfat_chain *p_dir, > > epold = exfat_get_dentry(sb, p_dir, oldentry + 1, &old_bh, > §or_old); > + if (!epold) > + return -EIO; … Will there be a need to reconsider the indentation for function call parameters in such source files? https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?id=b29482fde649c72441d5478a4ea2c52c56d97a5e#n93 Regards, Markus