* [PATCH] vdpa: ifcvf: Use dma_set_mask_and_coherent to simplify code
@ 2020-11-29 12:54 Christophe JAILLET
2020-11-30 2:20 ` Jason Wang
0 siblings, 1 reply; 2+ messages in thread
From: Christophe JAILLET @ 2020-11-29 12:54 UTC (permalink / raw)
To: mst, jasowang, lingshan.zhu, eli, parav
Cc: virtualization, linux-kernel, kernel-janitors, Christophe JAILLET
'pci_set_dma_mask()' + 'pci_set_consistent_dma_mask()' can be replaced by
an equivalent 'dma_set_mask_and_coherent()' which is much less verbose.
While at it, fix a typo (s/confiugration/configuration)
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
drivers/vdpa/ifcvf/ifcvf_main.c | 11 ++---------
1 file changed, 2 insertions(+), 9 deletions(-)
diff --git a/drivers/vdpa/ifcvf/ifcvf_main.c b/drivers/vdpa/ifcvf/ifcvf_main.c
index 8b4028556cb6..fa1af301cf55 100644
--- a/drivers/vdpa/ifcvf/ifcvf_main.c
+++ b/drivers/vdpa/ifcvf/ifcvf_main.c
@@ -417,16 +417,9 @@ static int ifcvf_probe(struct pci_dev *pdev, const struct pci_device_id *id)
return ret;
}
- ret = pci_set_dma_mask(pdev, DMA_BIT_MASK(64));
+ ret = dma_set_mask_and_coherent(dev, DMA_BIT_MASK(64));
if (ret) {
- IFCVF_ERR(pdev, "No usable DMA confiugration\n");
- return ret;
- }
-
- ret = pci_set_consistent_dma_mask(pdev, DMA_BIT_MASK(64));
- if (ret) {
- IFCVF_ERR(pdev,
- "No usable coherent DMA confiugration\n");
+ IFCVF_ERR(pdev, "No usable DMA configuration\n");
return ret;
}
--
2.27.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] vdpa: ifcvf: Use dma_set_mask_and_coherent to simplify code
2020-11-29 12:54 [PATCH] vdpa: ifcvf: Use dma_set_mask_and_coherent to simplify code Christophe JAILLET
@ 2020-11-30 2:20 ` Jason Wang
0 siblings, 0 replies; 2+ messages in thread
From: Jason Wang @ 2020-11-30 2:20 UTC (permalink / raw)
To: Christophe JAILLET, mst, lingshan.zhu, eli, parav
Cc: virtualization, linux-kernel, kernel-janitors
On 2020/11/29 下午8:54, Christophe JAILLET wrote:
> 'pci_set_dma_mask()' + 'pci_set_consistent_dma_mask()' can be replaced by
> an equivalent 'dma_set_mask_and_coherent()' which is much less verbose.
>
> While at it, fix a typo (s/confiugration/configuration)
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
Acked-by: Jason Wang <jasowang@redhat.com>
> drivers/vdpa/ifcvf/ifcvf_main.c | 11 ++---------
> 1 file changed, 2 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/vdpa/ifcvf/ifcvf_main.c b/drivers/vdpa/ifcvf/ifcvf_main.c
> index 8b4028556cb6..fa1af301cf55 100644
> --- a/drivers/vdpa/ifcvf/ifcvf_main.c
> +++ b/drivers/vdpa/ifcvf/ifcvf_main.c
> @@ -417,16 +417,9 @@ static int ifcvf_probe(struct pci_dev *pdev, const struct pci_device_id *id)
> return ret;
> }
>
> - ret = pci_set_dma_mask(pdev, DMA_BIT_MASK(64));
> + ret = dma_set_mask_and_coherent(dev, DMA_BIT_MASK(64));
> if (ret) {
> - IFCVF_ERR(pdev, "No usable DMA confiugration\n");
> - return ret;
> - }
> -
> - ret = pci_set_consistent_dma_mask(pdev, DMA_BIT_MASK(64));
> - if (ret) {
> - IFCVF_ERR(pdev,
> - "No usable coherent DMA confiugration\n");
> + IFCVF_ERR(pdev, "No usable DMA configuration\n");
> return ret;
> }
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-11-30 2:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-29 12:54 [PATCH] vdpa: ifcvf: Use dma_set_mask_and_coherent to simplify code Christophe JAILLET
2020-11-30 2:20 ` Jason Wang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).