archive mirror
 help / color / mirror / Atom feed
From: Colin Ian King <>
To: Dan Carpenter <>
Cc: David Airlie <>,
	Animesh Manna <>,,,,
	Rodrigo Vivi <>,,
	Maarten Lankhorst <>
Subject: Re: [PATCH] drm/i915/display: fix missing null check on allocated dsb object
Date: Tue, 16 Jun 2020 11:56:00 +0000	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <20200616115459.GN4151@kadam>

On 16/06/2020 12:54, Dan Carpenter wrote:
> On Tue, Jun 16, 2020 at 12:42:21PM +0100, Colin King wrote:
>> From: Colin Ian King <>
>> Currently there is no null check for a failed memory allocation
>> on the dsb object and without this a null pointer dereference
>> error can occur. Fix this by adding a null check.
>> Note: added a drm_err message in keeping with the error message style
>> in the function.
> Don't give in to peer pressure!  That's like being a lemming when Disney
> film makers come to push you off the cliff to create the 1958 nature
> film "White Wilderness".


> regards,
> dan carpenter

  reply	other threads:[~2020-06-16 11:56 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-16 11:42 [PATCH] drm/i915/display: fix missing null check on allocated dsb object Colin King
2020-06-16 11:54 ` Dan Carpenter
2020-06-16 11:56   ` Colin Ian King [this message]
2020-06-30 11:28     ` Jani Nikula

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).