kernel-janitors.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] soc/tegra: Fix an error handling path in 'tegra_powergate_power_up()'
@ 2021-06-27 15:54 Christophe JAILLET
  2021-06-28  8:28 ` Jon Hunter
  2021-10-07 18:02 ` Thierry Reding
  0 siblings, 2 replies; 3+ messages in thread
From: Christophe JAILLET @ 2021-06-27 15:54 UTC (permalink / raw)
  To: thierry.reding, jonathanh, digetx, ulf.hansson, maz, gustavoars, jckuo
  Cc: linux-tegra, linux-kernel, kernel-janitors, Christophe JAILLET

If an error occurs after a successful 'tegra_powergate_enable_clocks()'
call, it must be undone by a 'tegra_powergate_disable_clocks()' call, as
already done in the below and above error handling paths of this function.

Update the 'goto' to branch at the correct place of the error handling
path.

Fixes: a38045121bf4 ("soc/tegra: pmc: Add generic PM domain support")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
/!\ This patch is speculative /!\
Review with care.
---
 drivers/soc/tegra/pmc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/soc/tegra/pmc.c b/drivers/soc/tegra/pmc.c
index ea62f84d1c8b..b8ef9506f3de 100644
--- a/drivers/soc/tegra/pmc.c
+++ b/drivers/soc/tegra/pmc.c
@@ -782,7 +782,7 @@ static int tegra_powergate_power_up(struct tegra_powergate *pg,
 
 	err = reset_control_deassert(pg->reset);
 	if (err)
-		goto powergate_off;
+		goto disable_clks;
 
 	usleep_range(10, 20);
 
-- 
2.30.2


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] soc/tegra: Fix an error handling path in 'tegra_powergate_power_up()'
  2021-06-27 15:54 [PATCH] soc/tegra: Fix an error handling path in 'tegra_powergate_power_up()' Christophe JAILLET
@ 2021-06-28  8:28 ` Jon Hunter
  2021-10-07 18:02 ` Thierry Reding
  1 sibling, 0 replies; 3+ messages in thread
From: Jon Hunter @ 2021-06-28  8:28 UTC (permalink / raw)
  To: Christophe JAILLET, thierry.reding, digetx, ulf.hansson, maz,
	gustavoars, jckuo
  Cc: linux-tegra, linux-kernel, kernel-janitors


On 27/06/2021 16:54, Christophe JAILLET wrote:
> If an error occurs after a successful 'tegra_powergate_enable_clocks()'
> call, it must be undone by a 'tegra_powergate_disable_clocks()' call, as
> already done in the below and above error handling paths of this function.
> 
> Update the 'goto' to branch at the correct place of the error handling
> path.
> 
> Fixes: a38045121bf4 ("soc/tegra: pmc: Add generic PM domain support")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> /!\ This patch is speculative /!\
> Review with care.
> ---
>  drivers/soc/tegra/pmc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/soc/tegra/pmc.c b/drivers/soc/tegra/pmc.c
> index ea62f84d1c8b..b8ef9506f3de 100644
> --- a/drivers/soc/tegra/pmc.c
> +++ b/drivers/soc/tegra/pmc.c
> @@ -782,7 +782,7 @@ static int tegra_powergate_power_up(struct tegra_powergate *pg,
>  
>  	err = reset_control_deassert(pg->reset);
>  	if (err)
> -		goto powergate_off;
> +		goto disable_clks;
>  
>  	usleep_range(10, 20);


Thanks for the fix.

Reviewed-by: Jon Hunter <jonathanh@nvidia.com>

Cheers
Jon

-- 
nvpublic

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] soc/tegra: Fix an error handling path in 'tegra_powergate_power_up()'
  2021-06-27 15:54 [PATCH] soc/tegra: Fix an error handling path in 'tegra_powergate_power_up()' Christophe JAILLET
  2021-06-28  8:28 ` Jon Hunter
@ 2021-10-07 18:02 ` Thierry Reding
  1 sibling, 0 replies; 3+ messages in thread
From: Thierry Reding @ 2021-10-07 18:02 UTC (permalink / raw)
  To: Christophe JAILLET
  Cc: jonathanh, digetx, ulf.hansson, maz, gustavoars, jckuo,
	linux-tegra, linux-kernel, kernel-janitors

[-- Attachment #1: Type: text/plain, Size: 719 bytes --]

On Sun, Jun 27, 2021 at 05:54:31PM +0200, Christophe JAILLET wrote:
> If an error occurs after a successful 'tegra_powergate_enable_clocks()'
> call, it must be undone by a 'tegra_powergate_disable_clocks()' call, as
> already done in the below and above error handling paths of this function.
> 
> Update the 'goto' to branch at the correct place of the error handling
> path.
> 
> Fixes: a38045121bf4 ("soc/tegra: pmc: Add generic PM domain support")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> /!\ This patch is speculative /!\
> Review with care.
> ---
>  drivers/soc/tegra/pmc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks.

Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-10-07 18:02 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-27 15:54 [PATCH] soc/tegra: Fix an error handling path in 'tegra_powergate_power_up()' Christophe JAILLET
2021-06-28  8:28 ` Jon Hunter
2021-10-07 18:02 ` Thierry Reding

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).