From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jarkko Nikula Date: Mon, 17 Nov 2014 19:11:37 +0000 Subject: Re: ASoC: omap-mcbsp: Deletion of an unnecessary check before the function call "kfree" Message-Id: <546A4869.6010209@bitmer.com> List-Id: References: <5307CAA2.8060406@users.sourceforge.net> <530A086E.8010901@users.sourceforge.net> <530A72AA.3000601@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> <5469F4D5.9050908@users.sourceforge.net> In-Reply-To: <5469F4D5.9050908@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: SF Markus Elfring , Jaroslav Kysela , Liam Girdwood , Mark Brown , Peter Ujfalusi , Takashi Iwai , linux-omap@vger.kernel.org, alsa-devel@alsa-project.org Cc: kernel-janitors@vger.kernel.org, LKML , Coccinelle On 11/17/2014 03:15 PM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Mon, 17 Nov 2014 14:05:27 +0100 > > The kfree() function tests whether its argument is NULL and then > returns immediately. Thus the test around the call is not needed. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring > --- > sound/soc/omap/mcbsp.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > Acked-by: Jarkko Nikula