From mboxrd@z Thu Jan 1 00:00:00 1970 From: John Fastabend Date: Wed, 19 Nov 2014 16:47:47 +0000 Subject: Re: [PATCH 1/1] net: sched: Deletion of an unnecessary check before the function call "kfree" Message-Id: <546CC9B3.5060405@gmail.com> List-Id: References: <5307CAA2.8060406@users.sourceforge.net> <530A086E.8010901@users.sourceforge.net> <530A72AA.3000601@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> <546BAB93.4010406@users.sourceforge.net> In-Reply-To: <546BAB93.4010406@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: SF Markus Elfring Cc: "David S. Miller" , Jamal Hadi Salim , netdev@vger.kernel.org, LKML , kernel-janitors@vger.kernel.org, Coccinelle On 11/18/2014 12:26 PM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Tue, 18 Nov 2014 21:21:16 +0100 > > The kfree() function tests whether its argument is NULL and then > returns immediately. Thus the test around the call is not needed. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring > --- > net/sched/cls_bpf.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/net/sched/cls_bpf.c b/net/sched/cls_bpf.c > index 0e30d58..f323944 100644 > --- a/net/sched/cls_bpf.c > +++ b/net/sched/cls_bpf.c > @@ -212,8 +212,7 @@ static int cls_bpf_modify_existing(struct net *net, struct tcf_proto *tp, > > if (fp_old) > bpf_prog_destroy(fp_old); > - if (bpf_old) > - kfree(bpf_old); > + kfree(bpf_old); > > return 0; > > Maybe I need some coffee but I can't figure out what this patch is against... # grep bpf_old ./net/sched/cls_bpf.c # Marcus, what tree are you looking at? -- John Fastabend Intel Corporation