From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lino Sanfilippo Date: Sun, 30 Nov 2014 19:27:22 +0000 Subject: Re: [PATCH 1/1] net-PA Semi: Deletion of unnecessary checks before the function call "pci_dev_put" Message-Id: <547B6F9A.8030806@gmx.de> List-Id: References: <5307CAA2.8060406@users.sourceforge.net> <530A086E.8010901@users.sourceforge.net> <530A72AA.3000601@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> <547A09B1.9090102@users.sourceforge.net> <547B579F.10709@gmx.de> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Julia Lawall Cc: SF Markus Elfring , Olof Johansson , netdev@vger.kernel.org, LKML , kernel-janitors@vger.kernel.org On 30.11.2014 18:47, Julia Lawall wrote: > > I have heard of at least one case where the problem you are raising > happened in practice... > > julia If one case is known then there are probably a lot more that have not been discovered yet. Maybe this topic should be clarified somewhere (e.g. in "CodingStyle")? On the other hand i always found it obvious that its the callers responsibility to only pass sane parameters to the called functions... Regards, Lino