From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Szyprowski Date: Mon, 01 Dec 2014 09:46:23 +0000 Subject: Re: [PATCH 1/1] [media] V4L2: Deletion of an unnecessary check before the function call "vb2_put_vma Message-Id: <547C38EF.7030303@samsung.com> List-Id: References: <5307CAA2.8060406@users.sourceforge.net> <530A086E.8010901@users.sourceforge.net> <530A72AA.3000601@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> <547B98D5.8000909@users.sourceforge.net> In-Reply-To: <547B98D5.8000909@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: SF Markus Elfring , Kyungmin Park , Mauro Carvalho Chehab , Pawel Osciak , linux-media@vger.kernel.org Cc: LKML , kernel-janitors@vger.kernel.org, Julia Lawall Hello, On 2014-11-30 23:23, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sun, 30 Nov 2014 23:10:51 +0100 > > The vb2_put_vma() function tests whether its argument is NULL and then > returns immediately. Thus the test around the call is not needed. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring Acked-by: Marek Szyprowski > --- > drivers/media/v4l2-core/videobuf2-vmalloc.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/media/v4l2-core/videobuf2-vmalloc.c b/drivers/media/v4l2-core/videobuf2-vmalloc.c > index 3966b12..fba944e 100644 > --- a/drivers/media/v4l2-core/videobuf2-vmalloc.c > +++ b/drivers/media/v4l2-core/videobuf2-vmalloc.c > @@ -154,8 +154,7 @@ static void vb2_vmalloc_put_userptr(void *buf_priv) > } > kfree(buf->pages); > } else { > - if (buf->vma) > - vb2_put_vma(buf->vma); > + vb2_put_vma(buf->vma); > iounmap(buf->vaddr); > } > kfree(buf); Best regards -- Marek Szyprowski, PhD Samsung R&D Institute Poland