From mboxrd@z Thu Jan 1 00:00:00 1970 From: SF Markus Elfring Date: Mon, 01 Dec 2014 17:18:59 +0000 Subject: [PATCH 1/1] block-skd: Deletion of an unnecessary check before the function call "kfree" Message-Id: <547CA303.9000001@users.sourceforge.net> List-Id: References: <5307CAA2.8060406@users.sourceforge.net> <530A086E.8010901@users.sourceforge.net> <530A72AA.3000601@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> In-Reply-To: <5317A59D.4@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Linux Kernel Mailing List Cc: kernel-janitors@vger.kernel.org, Julia Lawall From: Markus Elfring Date: Mon, 1 Dec 2014 18:15:46 +0100 The kfree() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/block/skd_main.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/block/skd_main.c b/drivers/block/skd_main.c index 1e46eb2..c4b0259 100644 --- a/drivers/block/skd_main.c +++ b/drivers/block/skd_main.c @@ -3998,8 +3998,7 @@ static int skd_acquire_msix(struct skd_device *skdev) return 0; msix_out: - if (entries) - kfree(entries); + kfree(entries); skd_release_msix(skdev); return rc; } -- 2.1.3