From mboxrd@z Thu Jan 1 00:00:00 1970 From: SF Markus Elfring Date: Wed, 03 Dec 2014 09:10:41 +0000 Subject: Re: ARM: DaVinci: Deletion of an unnecessary check before the function call "__clk_disable" Message-Id: <547ED391.1050507@users.sourceforge.net> List-Id: References: <5307CAA2.8060406@users.sourceforge.net> <530A086E.8010901@users.sourceforge.net> <530A72AA.3000601@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> <547EC6B8.6000001@users.sourceforge.net> In-Reply-To: <547EC6B8.6000001@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable To: linux-arm-kernel@lists.infradead.org > The __clk_disable() function tests whether its argument is NULL and then > returns immediately. Thus the test around the call is not needed. I was a bit too quick to send you this notification. I stumbled once more on the detail that my source code analysis approach is incomplete for static functions so far. https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/tree/arch/= arm/mach-davinci/clock.c?id=A7ca2bcf2d2ef15c343a12f2a4c2e06380a0f495#n47 https://git.kernel.org/cgit/linux/kernel/git/stable/linux-stable.git/tree/d= rivers/clk/clk.c?idMc7ed32f398fa76b9e1d243a852420b1dad0150#n846 I would like to apologise for confusion I introduced here. Regards, Markus -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" = in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html