From mboxrd@z Thu Jan 1 00:00:00 1970 From: SF Markus Elfring Date: Sat, 20 Dec 2014 16:17:28 +0000 Subject: Re: [PATCH v2 0/6] net-PPP: Deletion of a few unnecessary checks Message-Id: <5495A118.8030802@users.sourceforge.net> List-Id: References: <548B1E44.6050005@users.sourceforge.net> <20141212.115922.687789059853236747.davem@davemloft.net> <54930D7C.3000901@users.sourceforge.net> <20141218.122556.2148647081075440879.davem@davemloft.net> <54958B8C.7010105@users.sourceforge.net> <54959A3A.4030104@gmx.de> In-Reply-To: <54959A3A.4030104@gmx.de> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Lino Sanfilippo Cc: David Miller , Sergei Shtylyov , Paul Mackerras , linux-ppp@vger.kernel.org, netdev@vger.kernel.org, Eric Dumazet , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Julia Lawall > I think what David said was pretty clear: If you see code like the above > there is no need to refactor it. I can understand this view in principle. > That does not mean that this is the _preferred_ way of error handling. Can your feedback help in the clarification of suggestions around my update steps one to six for this Linux software module? Regards, Markus