From mboxrd@z Thu Jan 1 00:00:00 1970 From: SF Markus Elfring Date: Sun, 18 Jan 2015 14:40:36 +0000 Subject: [PATCH 2/3] block-z2ram: Delete an unnecessary check before the function call "kfree" Message-Id: <54BBC5E4.10400@users.sourceforge.net> List-Id: References: <5307CAA2.8060406@users.sourceforge.net> <530A086E.8010901@users.sourceforge.net> <530A72AA.3000601@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> <54BBC3AB.6040207@users.sourceforge.net> In-Reply-To: <54BBC3AB.6040207@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: LKML Cc: kernel-janitors@vger.kernel.org, Julia Lawall From: Markus Elfring Date: Sun, 18 Jan 2015 12:28:27 +0100 The kfree() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/block/z2ram.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/block/z2ram.c b/drivers/block/z2ram.c index 968f9e5..c32f248 100644 --- a/drivers/block/z2ram.c +++ b/drivers/block/z2ram.c @@ -404,10 +404,7 @@ static void __exit z2_exit(void) } } - if ( z2ram_map != NULL ) - { - kfree( z2ram_map ); - } + kfree(z2ram_map); } return; -- 2.2.2