From mboxrd@z Thu Jan 1 00:00:00 1970 From: SF Markus Elfring Date: Thu, 22 Jan 2015 16:28:58 +0000 Subject: Re: [PATCH] MTD: Deletion of checks before the function call "iounmap" Message-Id: <54C1254A.4090106@users.sourceforge.net> List-Id: References: <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> <54BBE87C.9020705@users.sourceforge.net> <20150119175835.GH9759@ld-irv-0074> <54BD4AB6.70708@users.sourceforge.net> <20150119183057.GI9759@ld-irv-0074> <54BD55F6.6090609@users.sourceforge.net> <20150119203143.GL9759@ld-irv-0074> <54BD7E7D.9060107@users.sourceforge.net> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Brian Norris Cc: kernel-janitors@vger.kernel.org, LKML , Julia Lawall , Kyungmin Park , "linux-mtd@lists.infradead.org" , David Woodhouse > The only evidence I see is a long thread of similar patches from > the last several months, of varying (though not increasing) quality. I find it acceptable that some of my update suggestions do not fit to your quality expectations at the moment. > Prior objections to your approach were met with a distinct lack > of self-awareness on your part. I guess that a bit more clarification of this view will help to resolve some open issues, won't it? > I don't really see many challenges here to tackle, except for the > social issue of dealing with patch bots like you. I hope that you will like other automatic source code analysis results. > Your automated patches are generally not solving real problems, I try to clean-up Linux source files a bit. Problem solving with a higher value might follow ... > but they are at times introducing bugs. There are the usual different opinions and disagreements which might be still waiting for a constructive solution. Regards, Markus