From mboxrd@z Thu Jan 1 00:00:00 1970 From: SF Markus Elfring Date: Tue, 03 Feb 2015 08:36:01 +0000 Subject: [PATCH 2/2] sata_mv: More error handling for phy_power_off() in mv_platform_remove() Message-Id: <54D08871.6030304@users.sourceforge.net> List-Id: References: <5307CAA2.8060406@users.sourceforge.net> <530A086E.8010901@users.sourceforge.net> <530A72AA.3000601@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.so urceforge.net> <54D08732.4050601@users.sourceforge.net> In-Reply-To: <54D08732.4050601@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Tejun Heo , linux-ide@vger.kernel.org Cc: LKML , kernel-janitors@vger.kernel.org, Julia Lawall From: Markus Elfring Date: Mon, 2 Feb 2015 23:30:34 +0100 The return value from the phy_power_off() function was not used by the mv_platform_remove() function. Let us improve error detection and eventually return a corresponding failure code. Signed-off-by: Markus Elfring --- drivers/ata/sata_mv.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/ata/sata_mv.c b/drivers/ata/sata_mv.c index f8c33e3..4f9bc33 100644 --- a/drivers/ata/sata_mv.c +++ b/drivers/ata/sata_mv.c @@ -4203,7 +4203,7 @@ static int mv_platform_remove(struct platform_device *pdev) { struct ata_host *host = platform_get_drvdata(pdev); struct mv_host_priv *hpriv = host->private_data; - int port; + int port, rc; ata_host_detach(host); if (!IS_ERR(hpriv->clk)) { @@ -4215,7 +4215,9 @@ static int mv_platform_remove(struct platform_device *pdev) clk_disable_unprepare(hpriv->port_clks[port]); clk_put(hpriv->port_clks[port]); } - phy_power_off(hpriv->port_phys[port]); + rc = phy_power_off(hpriv->port_phys[port]); + if (rc) + return rc; } return 0; } -- 2.2.2