From mboxrd@z Thu Jan 1 00:00:00 1970 From: SF Markus Elfring Date: Thu, 05 Feb 2015 21:07:43 +0000 Subject: [PATCH] SCSI-bfa: Delete more unnecessary checks before the function call "vfree" Message-Id: <54D3DB9F.5040100@users.sourceforge.net> List-Id: References: <5307CAA2.8060406@users.sourceforge.net> <530A086E.8010901@users.sourceforge.net> <530A72AA.3000601@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.so urceforge.net> In-Reply-To: <5317A59D.4@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Anil Gurumurthy , "James E. J. Bottomley" , Sudarsana Kalluru , linux-scsi@vger.kernel.org Cc: LKML , kernel-janitors@vger.kernel.org, Julia Lawall From: Markus Elfring Date: Thu, 5 Feb 2015 22:02:16 +0100 The vfree() function performs also input parameter validation. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/scsi/bfa/bfad.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/bfa/bfad.c b/drivers/scsi/bfa/bfad.c index e90a374..05c8ca0 100644 --- a/drivers/scsi/bfa/bfad.c +++ b/drivers/scsi/bfa/bfad.c @@ -1810,11 +1810,11 @@ bfad_load_fwimg(struct pci_dev *pdev) static void bfad_free_fwimg(void) { - if (bfi_image_ct2_size && bfi_image_ct2) + if (bfi_image_ct2_size) vfree(bfi_image_ct2); - if (bfi_image_ct_size && bfi_image_ct) + if (bfi_image_ct_size) vfree(bfi_image_ct); - if (bfi_image_cb_size && bfi_image_cb) + if (bfi_image_cb_size) vfree(bfi_image_cb); } -- 2.2.2