From mboxrd@z Thu Jan 1 00:00:00 1970 From: SF Markus Elfring Date: Sat, 07 Feb 2015 17:23:42 +0000 Subject: Re: [PATCH 2/4] SCSI-QLA4...: Less function calls in qla4xxx_is_session_exists() after error detecti Message-Id: <54D64A1E.40405@users.sourceforge.net> List-Id: References: <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> <54D53BE4.7010807@users.sourceforge.net> <54D53CF1.8050009@users.sourceforge.net> <20150207093322.GA5206@mwanda> <20150207103249.GA5155@mwanda> In-Reply-To: <20150207103249.GA5155@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Dan Carpenter , Julia Lawall Cc: "James E. J. Bottomley" , QLogic-Storage-Upstream@qlogic.com, linux-scsi@vger.kernel.org, LKML , kernel-janitors@vger.kernel.org > 1) People gloss over initializers without reading them. I would find such a habit strange. > You shouldn't put complicated code in initializers. Does the affected memory allocation fall into such a category? > 2) It means you have to put a line of separation between the allocation > and the NULL check, but they should be next to each other. Would you like to extend the Linux coding style documentation? Regards, Markus