From mboxrd@z Thu Jan 1 00:00:00 1970 From: SF Markus Elfring Date: Thu, 25 Jun 2015 14:18:03 +0000 Subject: [PATCH] tools lib traceevent: Delete an unnecessary check before the function call "free_arg" Message-Id: <558C0D9B.80903@users.sourceforge.net> List-Id: References: <5307CAA2.8060406@users.sourceforge.net> <530A086E.8010901@users.sourceforge.net> <530A72AA.3000601@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> <5469FB58.4070205@users.sourceforge.net> In-Reply-To: <5469FB58.4070205@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-kernel@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, Julia Lawall From: Markus Elfring Date: Thu, 25 Jun 2015 16:13:47 +0200 The free_arg() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- tools/lib/traceevent/parse-filter.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/tools/lib/traceevent/parse-filter.c b/tools/lib/traceevent/parse-filter.c index 0144b3d..724a3be 100644 --- a/tools/lib/traceevent/parse-filter.c +++ b/tools/lib/traceevent/parse-filter.c @@ -1239,8 +1239,7 @@ filter_event(struct event_filter *filter, struct event_format *event, if (filter_type = NULL) return PEVENT_ERRNO__MEM_ALLOC_FAILED; - if (filter_type->filter) - free_arg(filter_type->filter); + free_arg(filter_type->filter); filter_type->filter = arg; return 0; -- 2.4.4