From mboxrd@z Thu Jan 1 00:00:00 1970 From: SF Markus Elfring Date: Sun, 28 Jun 2015 11:20:46 +0000 Subject: Re: [PATCH] drbd: Deletion of an unnecessary check before the function call "lc_destroy" Message-Id: <558FD88E.6070304@users.sourceforge.net> List-Id: References: <5307CAA2.8060406@users.sourceforge.net> <530A086E.8010901@users.sourceforge.net> <530A72AA.3000601@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> <546C9076.2030500@users.sourceforge.net> In-Reply-To: <546C9076.2030500@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Lars Ellenberg , drbd-user@lists.linbit.com Cc: LKML , kernel-janitors@vger.kernel.org, Julia Lawall > From: Markus Elfring > Date: Wed, 19 Nov 2014 13:33:32 +0100 > > The lc_destroy() function tests whether its argument is NULL and then > returns immediately. Thus the test around the call is not needed. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring > --- > drivers/block/drbd/drbd_nl.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/block/drbd/drbd_nl.c b/drivers/block/drbd/drbd_nl.c > index 1cd47df..0bcb3e0 100644 > --- a/drivers/block/drbd/drbd_nl.c > +++ b/drivers/block/drbd/drbd_nl.c > @@ -1115,8 +1115,7 @@ static int drbd_check_al_size(struct drbd_device *device, struct disk_conf *dc) > lc_destroy(n); > return -EBUSY; > } else { > - if (t) > - lc_destroy(t); > + lc_destroy(t); > } > drbd_md_mark_dirty(device); /* we changed device->act_log->nr_elemens */ > return 0; > Would you like to integrate this update suggestion into another source code repository? Regards, Markus