From mboxrd@z Thu Jan 1 00:00:00 1970 From: SF Markus Elfring Date: Tue, 30 Jun 2015 12:50:23 +0000 Subject: Re: [PATCH] SCSI-aic94xx: Deletion of an unnecessary check before the function call "kfree" Message-Id: <5592908F.6060205@users.sourceforge.net> List-Id: References: <5307CAA2.8060406@users.sourceforge.net> <530A086E.8010901@users.sourceforge.net> <530A72AA.3000601@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.so urceforge.net> <546E69D8.4040002@users.sourceforge.net> In-Reply-To: <546E69D8.4040002@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: "James E. J. Bottomley" , linux-scsi@vger.kernel.org Cc: LKML , kernel-janitors@vger.kernel.org, Julia Lawall > From: Markus Elfring > Date: Thu, 20 Nov 2014 23:18:56 +0100 > > The kfree() function tests whether its argument is NULL and then > returns immediately. Thus the test around the call is not needed. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring > --- > drivers/scsi/aic94xx/aic94xx_init.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/scsi/aic94xx/aic94xx_init.c b/drivers/scsi/aic94xx/aic94xx_init.c > index c56741f..0bfdcba 100644 > --- a/drivers/scsi/aic94xx/aic94xx_init.c > +++ b/drivers/scsi/aic94xx/aic94xx_init.c > @@ -597,8 +597,7 @@ static void asd_destroy_ha_caches(struct asd_ha_struct *asd_ha) > if (asd_ha->hw_prof.scb_ext) > asd_free_coherent(asd_ha, asd_ha->hw_prof.scb_ext); > > - if (asd_ha->hw_prof.ddb_bitmap) > - kfree(asd_ha->hw_prof.ddb_bitmap); > + kfree(asd_ha->hw_prof.ddb_bitmap); > asd_ha->hw_prof.ddb_bitmap = NULL; > > for (i = 0; i < ASD_MAX_PHYS; i++) { > How are the chances to integrate this update suggestion into another source code repository? Regards, Markus