From mboxrd@z Thu Jan 1 00:00:00 1970 From: SF Markus Elfring Date: Tue, 30 Jun 2015 12:52:35 +0000 Subject: Re: [PATCH] SCSI-eata_pio: Deletion of an unnecessary check before the function call "pci_dev_put" Message-Id: <55929113.8070206@users.sourceforge.net> List-Id: References: <5307CAA2.8060406@users.sourceforge.net> <530A086E.8010901@users.sourceforge.net> <530A72AA.3000601@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.so urceforge.net> <546E441B.7040004@users.sourceforge.net> In-Reply-To: <546E441B.7040004@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: "James E. J. Bottomley" , linux-scsi@vger.kernel.org Cc: LKML , kernel-janitors@vger.kernel.org, Julia Lawall > From: Markus Elfring > Date: Thu, 20 Nov 2014 20:37:30 +0100 > > The pci_dev_put() function tests whether its argument is NULL and then > returns immediately. Thus the test around the call is not needed. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring > --- > drivers/scsi/eata_pio.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/scsi/eata_pio.c b/drivers/scsi/eata_pio.c > index 8319d2b..707f64d 100644 > --- a/drivers/scsi/eata_pio.c > +++ b/drivers/scsi/eata_pio.c > @@ -122,8 +122,7 @@ static int eata_pio_release(struct Scsi_Host *sh) > release_region(sh->io_port, sh->n_io_port); > } > /* At this point the PCI reference can go */ > - if (hd->pdev) > - pci_dev_put(hd->pdev); > + pci_dev_put(hd->pdev); > return 1; > } > > Would you like to integrate this update suggestion into another source code repository? Regards, Markus