From mboxrd@z Thu Jan 1 00:00:00 1970 From: SF Markus Elfring Date: Sat, 04 Jul 2015 08:10:33 +0000 Subject: [PATCH] kprobes: Delete an unnecessary check before the function call "module_put" Message-Id: <559794F9.3050800@users.sourceforge.net> List-Id: References: <5307CAA2.8060406@users.sourceforge.net> <530A086E.8010901@users.sourceforge.net> <530A72AA.3000601@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> <546899CF.8020808@users.sourceforge.net> <5469B08E.90104@hitachi.com> <546C41EF.4040502@users.sourceforge.net> <546D65C6.3030109@hitachi.com> In-Reply-To: <546D65C6.3030109@hitachi.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Ananth N Mavinakayanahalli , Anil S Keshavamurthy , "David S. Miller" , Masami Hiramatsu Cc: LKML , kernel-janitors@vger.kernel.org, Julia Lawall From: Markus Elfring Date: Sat, 4 Jul 2015 10:00:26 +0200 The module_put() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- kernel/kprobes.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/kernel/kprobes.c b/kernel/kprobes.c index c90e417..52e3529 100644 --- a/kernel/kprobes.c +++ b/kernel/kprobes.c @@ -1531,10 +1531,7 @@ int register_kprobe(struct kprobe *p) out: mutex_unlock(&kprobe_mutex); - - if (probed_mod) - module_put(probed_mod); - + module_put(probed_mod); return ret; } EXPORT_SYMBOL_GPL(register_kprobe); -- 2.4.5