From mboxrd@z Thu Jan 1 00:00:00 1970 From: SF Markus Elfring Date: Wed, 08 Jul 2015 17:48:13 +0000 Subject: Re: [PATCH] bcache: Deletion of an unnecessary check before the function call "kobject_put" Message-Id: <559D625D.2020408@users.sourceforge.net> List-Id: References: <5307CAA2.8060406@users.sourceforge.net> <530A086E.8010901@users.sourceforge.net> <530A72AA.3000601@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> <546CFECC.8020309@users.sourceforge.net> In-Reply-To: <546CFECC.8020309@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Kent Overstreet , Neil Brown , linux-bcache@vger.kernel.org Cc: linux-raid@vger.kernel.org, LKML , kernel-janitors@vger.kernel.org, Julia Lawall > From: Markus Elfring > Date: Wed, 19 Nov 2014 21:25:39 +0100 > > The kobject_put() function tests whether its argument is NULL and then > returns immediately. Thus the test around the call is not needed. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring > --- > drivers/md/bcache/super.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/md/bcache/super.c b/drivers/md/bcache/super.c > index d4713d0..1443c55 100644 > --- a/drivers/md/bcache/super.c > +++ b/drivers/md/bcache/super.c > @@ -2076,8 +2076,7 @@ static void bcache_exit(void) > { > bch_debug_exit(); > bch_request_exit(); > - if (bcache_kobj) > - kobject_put(bcache_kobj); > + kobject_put(bcache_kobj); > if (bcache_wq) > destroy_workqueue(bcache_wq); > if (bcache_major) > Would you like to integrate this update suggestion into another source code repository? Regards, Markus