From: walter harms <wharms@bfs.de>
To: kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] lib/string.c: check for kmalloc() failure
Date: Thu, 17 Aug 2017 12:28:10 +0000 [thread overview]
Message-ID: <59958BDA.6010309@bfs.de> (raw)
In-Reply-To: <20170817115420.uikisjvfmtrqkzjn@mwanda>
Am 17.08.2017 13:54, schrieb Dan Carpenter:
> This is mostly to keep the number of static checker warnings down so
> we can spot new bugs instead of them being drowned in noise. This
> function doesn't return normal kernel error codes but instead the return
> value is used to display exactly which memory failed. I chose -1 as
> hopefully that's a helpful thing to print.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/lib/string.c b/lib/string.c
> index 661a6a6173c0..59e112cbcf22 100644
> --- a/lib/string.c
> +++ b/lib/string.c
> @@ -1058,7 +1058,11 @@ EXPORT_SYMBOL(fortify_overflow);
> static __init int memset16_selftest(void)
> {
> unsigned i, j, k;
> - u16 v, *p = kmalloc(256 * 2 * 2, GFP_KERNEL);
> + u16 v, *p;
> +
> + p = kmalloc(256 * 2 * 2, GFP_KERNEL);
> + if (!p)
> + return -1;
>
> for (i = 0; i < 256; i++) {
> for (j = 0; j < 256; j++) {
> @@ -1090,7 +1094,11 @@ static __init int memset16_selftest(void)
> static __init int memset32_selftest(void)
> {
> unsigned i, j, k;
> - u32 v, *p = kmalloc(256 * 2 * 4, GFP_KERNEL);
> + u32 v, *p;
> +
> + p = kmalloc(256 * 2 * 4, GFP_KERNEL);
> + if (!p)
> + return -1;
>
> for (i = 0; i < 256; i++) {
> for (j = 0; j < 256; j++) {
> @@ -1122,7 +1130,11 @@ static __init int memset32_selftest(void)
> static __init int memset64_selftest(void)
> {
> unsigned i, j, k;
> - u64 v, *p = kmalloc(256 * 2 * 8, GFP_KERNEL);
> + u64 v, *p;
> +
> + p = kmalloc(256 * 2 * 8, GFP_KERNEL);
> + if (!p)
> + return -1;
I assume that the multiplier 2/4/8 means sizeof(uX).
The 256 is an arbitrary block size but the *2 left me puzzled.
Could anybody (not necessarily Dan) drop a few helpful comments
for these numbers ?
re,
wh
>
> for (i = 0; i < 256; i++) {
> for (j = 0; j < 256; j++) {
> --
> To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
prev parent reply other threads:[~2017-08-17 12:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-17 11:54 [PATCH] lib/string.c: check for kmalloc() failure Dan Carpenter
2017-08-17 12:28 ` walter harms [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=59958BDA.6010309@bfs.de \
--to=wharms@bfs.de \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).