From: Markus Elfring <Markus.Elfring@web.de>
To: Liao Pingfang <liao.pingfang@zte.com.cn>, linux-btrfs@vger.kernel.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
Chris Mason <clm@fb.com>, David Sterba <dsterba@suse.com>,
Josef Bacik <josef@toxicpanda.com>,
Wang Liang <wang.liang82@zte.com.cn>,
Xue Zhihong <xue.zhihong@zte.com.cn>,
Yi Wang <wang.yi59@zte.com.cn>
Subject: Re: [PATCH v2] btrfs: Remove error messages for failed memory allocations
Date: Thu, 11 Jun 2020 14:00:21 +0000 [thread overview]
Message-ID: <59c4741e-5749-4782-33f8-cc3a30ecf5e5@web.de> (raw)
> As there is a dump_stack() done on memory allocation
> failures, these messages might as well be deleted instead.
* I imagine that an other wording variant can become clearer
for the change description.
* I suggest to reconsider the patch subject.
…
> +++ b/fs/btrfs/check-integrity.c
> @@ -632,7 +632,6 @@ static int btrfsic_process_superblock(struct btrfsic_state *state,
>
> selected_super = kzalloc(sizeof(*selected_super), GFP_NOFS);
> if (NULL == selected_super) {
> - pr_info("btrfsic: error, kmalloc failed!\n");
> return -ENOMEM;
> }
How do you think about to use the following error handling instead?
if (!selected_super)
return -ENOMEM;
Regards,
Markus
next reply other threads:[~2020-06-11 14:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-11 14:00 Markus Elfring [this message]
2020-06-11 14:00 ` [PATCH v2] btrfs: Remove error messages for failed memory allocations Markus Elfring
2020-06-11 14:19 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=59c4741e-5749-4782-33f8-cc3a30ecf5e5@web.de \
--to=markus.elfring@web.de \
--cc=clm@fb.com \
--cc=dsterba@suse.com \
--cc=josef@toxicpanda.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=liao.pingfang@zte.com.cn \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wang.liang82@zte.com.cn \
--cc=wang.yi59@zte.com.cn \
--cc=xue.zhihong@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).