kernel-janitors.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Re: [PATCH] Input: stmfts: fix ref count leak in stmfts_input_open
@ 2020-06-14  9:33 Markus Elfring
  0 siblings, 0 replies; only message in thread
From: Markus Elfring @ 2020-06-14  9:33 UTC (permalink / raw)
  To: Navid Emamdoost, linux-arm-kernel, linux-input, linux-stm32
  Cc: Navid Emamdoost, Kangjie Lu, Stephen McCamant, Qiushi Wu,
	Alexandre Torgue, Dmitry Torokhov, Maxime Coquelin,
	kernel-janitors, linux-kernel

> in stmfts_input_open, …

* Can the term “reference count” become relevant also for this commit message
  besides other possible adjustments?

* Would you like to add the tag “Fixes”?


…
> +++ b/drivers/input/touchscreen/stmfts.c
> @@ -367,6 +367,9 @@  static int stmfts_input_open(struct input_dev *dev)
>  	}
>
>  	return 0;
> +out:
> +	pm_runtime_put(&sdata->client->dev);
> +	return err;
>  }
…

Perhaps use the label “put_runtime” instead?

Regards,
Markus

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2020-06-14  9:33 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-14  9:33 [PATCH] Input: stmfts: fix ref count leak in stmfts_input_open Markus Elfring

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).