* [PATCH] atm: idt77252: clean up trigraph warning on ??) string
@ 2021-07-20 12:48 Colin King
2021-07-20 17:17 ` Nathan Chancellor
0 siblings, 1 reply; 3+ messages in thread
From: Colin King @ 2021-07-20 12:48 UTC (permalink / raw)
To: Chas Williams, Nathan Chancellor, Nick Desaulniers,
linux-atm-general, netdev, clang-built-linux
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
The character sequence ??) is a trigraph and causes the following
clang warning:
drivers/atm/idt77252.c:3544:35: warning: trigraph ignored [-Wtrigraphs]
Clean this by replacing it with single ?.
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/atm/idt77252.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/atm/idt77252.c b/drivers/atm/idt77252.c
index 9e4bd751db79..81ce81a75fc6 100644
--- a/drivers/atm/idt77252.c
+++ b/drivers/atm/idt77252.c
@@ -3536,7 +3536,7 @@ static int idt77252_preset(struct idt77252_dev *card)
return -1;
}
if (!(pci_command & PCI_COMMAND_IO)) {
- printk("%s: PCI_COMMAND: %04x (???)\n",
+ printk("%s: PCI_COMMAND: %04x (?)\n",
card->name, pci_command);
deinit_card(card);
return (-1);
--
2.31.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] atm: idt77252: clean up trigraph warning on ??) string
2021-07-20 12:48 [PATCH] atm: idt77252: clean up trigraph warning on ??) string Colin King
@ 2021-07-20 17:17 ` Nathan Chancellor
2021-07-20 17:21 ` Colin Ian King
0 siblings, 1 reply; 3+ messages in thread
From: Nathan Chancellor @ 2021-07-20 17:17 UTC (permalink / raw)
To: Colin King, Chas Williams, Nick Desaulniers, linux-atm-general,
netdev, clang-built-linux
Cc: kernel-janitors, linux-kernel
On 7/20/2021 5:48 AM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The character sequence ??) is a trigraph and causes the following
> clang warning:
>
> drivers/atm/idt77252.c:3544:35: warning: trigraph ignored [-Wtrigraphs]
>
> Clean this by replacing it with single ?.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
This looks good to me but I am curious how you say this warning in the
first place since the main Makefile disables this unconditionally. Did
you just pass -Wtrigraphs via KCFLAGS or something similar?
Reviewed-by: Nathan Chancellor <nathan@kernel.org>
> ---
> drivers/atm/idt77252.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/atm/idt77252.c b/drivers/atm/idt77252.c
> index 9e4bd751db79..81ce81a75fc6 100644
> --- a/drivers/atm/idt77252.c
> +++ b/drivers/atm/idt77252.c
> @@ -3536,7 +3536,7 @@ static int idt77252_preset(struct idt77252_dev *card)
> return -1;
> }
> if (!(pci_command & PCI_COMMAND_IO)) {
> - printk("%s: PCI_COMMAND: %04x (???)\n",
> + printk("%s: PCI_COMMAND: %04x (?)\n",
> card->name, pci_command);
> deinit_card(card);
> return (-1);
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] atm: idt77252: clean up trigraph warning on ??) string
2021-07-20 17:17 ` Nathan Chancellor
@ 2021-07-20 17:21 ` Colin Ian King
0 siblings, 0 replies; 3+ messages in thread
From: Colin Ian King @ 2021-07-20 17:21 UTC (permalink / raw)
To: Nathan Chancellor, Chas Williams, Nick Desaulniers,
linux-atm-general, netdev, clang-built-linux
Cc: kernel-janitors, linux-kernel
On 20/07/2021 18:17, Nathan Chancellor wrote:
> On 7/20/2021 5:48 AM, Colin King wrote:
>> From: Colin Ian King <colin.king@canonical.com>
>>
>> The character sequence ??) is a trigraph and causes the following
>> clang warning:
>>
>> drivers/atm/idt77252.c:3544:35: warning: trigraph ignored [-Wtrigraphs]
>>
>> Clean this by replacing it with single ?.
>>
>> Signed-off-by: Colin Ian King <colin.king@canonical.com>
>
> This looks good to me but I am curious how you say this warning in the
> first place since the main Makefile disables this unconditionally. Did
> you just pass -Wtrigraphs via KCFLAGS or something similar?
I used W=1
>
> Reviewed-by: Nathan Chancellor <nathan@kernel.org>
>
>> ---
>> drivers/atm/idt77252.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/atm/idt77252.c b/drivers/atm/idt77252.c
>> index 9e4bd751db79..81ce81a75fc6 100644
>> --- a/drivers/atm/idt77252.c
>> +++ b/drivers/atm/idt77252.c
>> @@ -3536,7 +3536,7 @@ static int idt77252_preset(struct idt77252_dev
>> *card)
>> return -1;
>> }
>> if (!(pci_command & PCI_COMMAND_IO)) {
>> - printk("%s: PCI_COMMAND: %04x (???)\n",
>> + printk("%s: PCI_COMMAND: %04x (?)\n",
>> card->name, pci_command);
>> deinit_card(card);
>> return (-1);
>>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-07-20 17:22 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-20 12:48 [PATCH] atm: idt77252: clean up trigraph warning on ??) string Colin King
2021-07-20 17:17 ` Nathan Chancellor
2021-07-20 17:21 ` Colin Ian King
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).