archive mirror
 help / color / mirror / Atom feed
From: Markus Elfring <>
To: Bo YU <>,
	Alexandre Chartre <>,
	Andy Lutomirski <>, Borislav Petkov <>,
	Dave Hansen <>,
	"H. Peter Anvin" <>, Ingo Molnar <>,
	Jann Horn <>, Kees Cook <>,
	Peter Zijlstra <>,
	Thomas Gleixner <>
Subject: Re: [PATCH] arch/x86: Check return value from a notify_die() call
Date: Mon, 22 Jun 2020 06:50:59 +0000	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

>>> This is detected by Coverity scan: #CID: 1464472(CHECKED_RETURN)

Can an additional imperative wording be helpful for the change description
(besides an adjusted patch subject)?

>>> FIXES: c94082656dac7(x86: Use enum instead of literals for trap values)
>> Is the following tag specification more appropriate?
>> Fixes: c94082656dac7 ("x86: Use enum instead of literals for trap values")
> Your description looks like more appropriate, thank you.

Thanks for your positive feedback.

> But I want to receive suggestions from other reviewers also. So I will
> send V2 patch as your point once got confirmed. Sorry.

Should the confirmation be sufficient from the available software documentation?

I am curious if this patch review will clarify more aspects.


      reply	other threads:[~2020-06-22  6:50 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-21 14:40 [PATCH] arch/x86: Check return value from a notify_die() call Markus Elfring
2020-06-22  0:50 ` Bo YU
2020-06-22  6:50   ` Markus Elfring [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).