kernel-janitors.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jason Wang <jasowang@redhat.com>
To: Dan Carpenter <dan.carpenter@oracle.com>,
	"Michael S. Tsirkin" <mst@redhat.com>
Cc: Eli Cohen <elic@nvidia.com>,
	Stefano Garzarella <sgarzare@redhat.com>,
	virtualization@lists.linux-foundation.org,
	kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] vdpa: fix error code in vp_vdpa_probe()
Date: Mon, 7 Jun 2021 10:23:38 +0800	[thread overview]
Message-ID: <696c510d-b9af-60a4-e517-b2f749a10f41@redhat.com> (raw)
In-Reply-To: <YLtyYE8TinOl3IhO@mwanda>


在 2021/6/5 下午8:47, Dan Carpenter 写道:
> Return -ENOMEM if vp_modern_map_vq_notify() fails.  Currently it
> returns success.
>
> Fixes: 11d8ffed00b2 ("vp_vdpa: switch to use vp_modern_map_vq_notify()")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
>   drivers/vdpa/virtio_pci/vp_vdpa.c | 1 +
>   1 file changed, 1 insertion(+)


Acked-by: Jason Wang <jasowang@redhat.com>

Thanks


>
> diff --git a/drivers/vdpa/virtio_pci/vp_vdpa.c b/drivers/vdpa/virtio_pci/vp_vdpa.c
> index c76ebb531212..e5d92db728d3 100644
> --- a/drivers/vdpa/virtio_pci/vp_vdpa.c
> +++ b/drivers/vdpa/virtio_pci/vp_vdpa.c
> @@ -442,6 +442,7 @@ static int vp_vdpa_probe(struct pci_dev *pdev, const struct pci_device_id *id)
>   			vp_modern_map_vq_notify(mdev, i,
>   						&vp_vdpa->vring[i].notify_pa);
>   		if (!vp_vdpa->vring[i].notify) {
> +			ret = -ENOMEM;
>   			dev_warn(&pdev->dev, "Fail to map vq notify %d\n", i);
>   			goto err;
>   		}


  reply	other threads:[~2021-06-07  2:23 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-05 12:47 [PATCH] vdpa: fix error code in vp_vdpa_probe() Dan Carpenter
2021-06-07  2:23 ` Jason Wang [this message]
2021-06-07  7:51 ` Stefano Garzarella

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=696c510d-b9af-60a4-e517-b2f749a10f41@redhat.com \
    --to=jasowang@redhat.com \
    --cc=dan.carpenter@oracle.com \
    --cc=elic@nvidia.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=sgarzare@redhat.com \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).