From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
To: Markus Elfring <Markus.Elfring@web.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: kernel-janitors@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] cxl: Reduce scope for the variable =?UTF-8?B?4oCcbW3igJ0gaW4gY3hsbG
Date: Thu, 10 Dec 2020 18:01:36 +0000 [thread overview]
Message-ID: <6da89e4e-1f29-0dde-ad5b-a168f4cc1e85@wanadoo.fr> (raw)
In-Reply-To: <507d607a-0551-ec11-e1dc-5b9c96a361cb@web.de>
Le 10/12/2020 à 17:04, Markus Elfring a écrit :
>>> A local variable was used only within an if branch.
>>> Thus move the definition for the variable “mm” into the corresponding
>>> code block.
>>
>> You did nothing here except add a checkpatch warning :(
>
> elfring@Sonne:~/Projekte/Linux/next-patched> scripts/checkpatch.pl /home/elfring/Projekte/Bau/Linux/scripts/Coccinelle/tuning1/next/20201204/Flicken/0001-cxl-Reduce-scope-for-the-variable-mm-in-cxllib_get_P.patch
> total: 0 errors, 0 warnings, 16 lines checked
>
> Regards,
> Markus
>
Maybe:
script/checkpatch.pl -f drivers/misc/cxl/cxllib.c
?
prev parent reply other threads:[~2020-12-10 18:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <5cee2b25-71e0-15aa-fba6-12211b8308aa@web.de>
2020-12-10 14:47 ` [PATCH] cxl: Reduce scope for the variable “mm” in cxllib_ Greg Kroah-Hartman
[not found] ` <507d607a-0551-ec11-e1dc-5b9c96a361cb@web.de>
2020-12-10 18:01 ` Christophe JAILLET [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6da89e4e-1f29-0dde-ad5b-a168f4cc1e85@wanadoo.fr \
--to=christophe.jaillet@wanadoo.fr \
--cc=Markus.Elfring@web.de \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).