From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
To: Colin King <colin.king@canonical.com>,
Ryder Lee <ryder.lee@mediatek.com>,
Jianjun Wang <jianjun.wang@mediatek.com>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Rob Herring <robh@kernel.org>,
Bjorn Helgaas <bhelgaas@google.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
linux-pci@vger.kernel.org, linux-mediatek@lists.infradead.org,
linux-arm-kernel@lists.infradead.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH][next] PCI: mediatek-gen3: Add missing null pointer check
Date: Fri, 30 Apr 2021 09:47:06 +0200 [thread overview]
Message-ID: <7a512e3a-2897-ac12-ac6e-06be28735279@wanadoo.fr> (raw)
In-Reply-To: <20210429110040.63119-1-colin.king@canonical.com>
Le 29/04/2021 à 13:00, Colin King a écrit :
> From: Colin Ian King <colin.king@canonical.com>
>
> The call to platform_get_resource_byname can potentially return null, so
> add a null pointer check to avoid a null pointer dereference issue.
>
> Addresses-Coverity: ("Dereference null return")
> Fixes: 441903d9e8f0 ("PCI: mediatek-gen3: Add MediaTek Gen3 driver for MT8192")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/pci/controller/pcie-mediatek-gen3.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/pci/controller/pcie-mediatek-gen3.c b/drivers/pci/controller/pcie-mediatek-gen3.c
> index 20165e4a75b2..3c5b97716d40 100644
> --- a/drivers/pci/controller/pcie-mediatek-gen3.c
> +++ b/drivers/pci/controller/pcie-mediatek-gen3.c
> @@ -721,6 +721,8 @@ static int mtk_pcie_parse_port(struct mtk_pcie_port *port)
> int ret;
>
> regs = platform_get_resource_byname(pdev, IORESOURCE_MEM, "pcie-mac");
> + if (!regs)
> + return -EINVAL;
> port->base = devm_ioremap_resource(dev, regs);
> if (IS_ERR(port->base)) {
> dev_err(dev, "failed to map register base\n");
>
Nitpick:
Using 'devm_platform_ioremap_resource_byname' is slightly less
verbose and should please Coverity.
Also, which git repo are you using? On linux-next ([1)], your proposed
patch is already part of "PCI: mediatek-gen3: Add MediaTek Gen3 driver
for MT8192".
[1]:
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/log/drivers/pci/controller/pcie-mediatek-gen3.c
CJ
next prev parent reply other threads:[~2021-04-30 7:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-29 11:00 [PATCH][next] PCI: mediatek-gen3: Add missing null pointer check Colin King
2021-04-30 7:24 ` Jianjun Wang
2021-04-30 7:47 ` Christophe JAILLET [this message]
2021-04-30 16:34 ` Bjorn Helgaas
2021-05-03 7:03 ` Dan Carpenter
2021-04-30 8:40 ` Lorenzo Pieralisi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7a512e3a-2897-ac12-ac6e-06be28735279@wanadoo.fr \
--to=christophe.jaillet@wanadoo.fr \
--cc=bhelgaas@google.com \
--cc=colin.king@canonical.com \
--cc=jianjun.wang@mediatek.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=robh@kernel.org \
--cc=ryder.lee@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).