From: Tariq Toukan <tariqt@mellanox.com>
To: Colin King <colin.king@canonical.com>,
Boris Pismenny <borisp@mellanox.com>,
Saeed Mahameed <saeedm@mellanox.com>,
Leon Romanovsky <leon@kernel.org>,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
netdev@vger.kernel.org, linux-rdma@vger.kernel.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH][next] net/mlx5e: fix memory leak of tls
Date: Tue, 30 Jun 2020 16:30:15 +0000 [thread overview]
Message-ID: <7c3bb6e8-6658-1a73-b5c7-b70bc6255576@mellanox.com> (raw)
In-Reply-To: <20200630151646.517757-1-colin.king@canonical.com>
On 6/30/2020 6:16 PM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The error return path when create_singlethread_workqueue fails currently
> does not kfree tls and leads to a memory leak. Fix this by kfree'ing
> tls before returning -ENOMEM.
>
> Addresses-Coverity: ("Resource leak")
> Fixes: 1182f3659357 ("net/mlx5e: kTLS, Add kTLS RX HW offload support")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/net/ethernet/mellanox/mlx5/core/en_accel/tls.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/tls.c b/drivers/net/ethernet/mellanox/mlx5/core/en_accel/tls.c
> index 99beb928feff..fee991f5ee7c 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/tls.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_accel/tls.c
> @@ -232,8 +232,10 @@ int mlx5e_tls_init(struct mlx5e_priv *priv)
> return -ENOMEM;
>
> tls->rx_wq = create_singlethread_workqueue("mlx5e_tls_rx");
> - if (!tls->rx_wq)
> + if (!tls->rx_wq) {
> + kfree(tls);
> return -ENOMEM;
> + }
>
> priv->tls = tls;
> return 0;
>
Reviewed-by: Tariq Toukan <tariqt@mellanox.com>
Thanks.
next prev parent reply other threads:[~2020-06-30 16:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-30 15:16 [PATCH][next] net/mlx5e: fix memory leak of tls Colin King
2020-06-30 16:30 ` Tariq Toukan [this message]
2020-06-30 20:38 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7c3bb6e8-6658-1a73-b5c7-b70bc6255576@mellanox.com \
--to=tariqt@mellanox.com \
--cc=borisp@mellanox.com \
--cc=colin.king@canonical.com \
--cc=davem@davemloft.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=saeedm@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).