* [PATCH 0/3] crypto: qat - Fixes and clean-ups
@ 2021-07-11 6:12 Christophe JAILLET
2021-07-11 6:13 ` [PATCH 1/3] crypto: qat - Simplify code and axe the use of a deprecated API Christophe JAILLET
` (3 more replies)
0 siblings, 4 replies; 6+ messages in thread
From: Christophe JAILLET @ 2021-07-11 6:12 UTC (permalink / raw)
To: giovanni.cabiddu, herbert, davem, tomaszx.kowalik,
marco.chiappero, andriy.shevchenko, fiona.trahe, wojciech.ziemba,
ztong0001, qat-linux
Cc: linux-crypto, linux-kernel, kernel-janitors, Christophe JAILLET
The only link between these 3 patches are that they are all related to
'drivers/crypto/qat'.
Christophe JAILLET (3):
crypto: qat - Simplify code and axe the use of a deprecated API
crypto: qat - Disable AER if an error occurs in probe functions
crypto: qat - Fix a typo in a comment
drivers/crypto/qat/qat_4xxx/adf_drv.c | 8 ++------
drivers/crypto/qat/qat_c3xxx/adf_drv.c | 15 ++++++---------
drivers/crypto/qat/qat_c3xxxvf/adf_drv.c | 9 ++-------
drivers/crypto/qat/qat_c62x/adf_drv.c | 15 ++++++---------
drivers/crypto/qat/qat_c62xvf/adf_drv.c | 9 ++-------
drivers/crypto/qat/qat_common/adf_aer.c | 2 +-
drivers/crypto/qat/qat_dh895xcc/adf_drv.c | 15 ++++++---------
drivers/crypto/qat/qat_dh895xccvf/adf_drv.c | 9 ++-------
8 files changed, 27 insertions(+), 55 deletions(-)
--
2.30.2
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 1/3] crypto: qat - Simplify code and axe the use of a deprecated API
2021-07-11 6:12 [PATCH 0/3] crypto: qat - Fixes and clean-ups Christophe JAILLET
@ 2021-07-11 6:13 ` Christophe JAILLET
2021-07-12 10:20 ` Andy Shevchenko
2021-07-11 6:13 ` [PATCH 2/3] crypto: qat - Disable AER if an error occurs in probe functions Christophe JAILLET
` (2 subsequent siblings)
3 siblings, 1 reply; 6+ messages in thread
From: Christophe JAILLET @ 2021-07-11 6:13 UTC (permalink / raw)
To: giovanni.cabiddu, herbert, davem, tomaszx.kowalik,
marco.chiappero, andriy.shevchenko, fiona.trahe, wojciech.ziemba,
ztong0001, qat-linux
Cc: linux-crypto, linux-kernel, kernel-janitors, Christophe JAILLET
The wrappers in include/linux/pci-dma-compat.h should go away.
Replace 'pci_set_dma_mask/pci_set_consistent_dma_mask' by an equivalent
and less verbose 'dma_set_mask_and_coherent()' call.
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
If needed, see post from Christoph Hellwig on the kernel-janitors ML:
https://marc.info/?l=kernel-janitors&m=158745678307186&w=4
We could also reduce indentation by merging the 2 'if' together. If this
is the preferred style, I'll send a v2.
---
drivers/crypto/qat/qat_4xxx/adf_drv.c | 8 ++------
drivers/crypto/qat/qat_c3xxx/adf_drv.c | 9 ++-------
drivers/crypto/qat/qat_c3xxxvf/adf_drv.c | 9 ++-------
drivers/crypto/qat/qat_c62x/adf_drv.c | 9 ++-------
drivers/crypto/qat/qat_c62xvf/adf_drv.c | 9 ++-------
drivers/crypto/qat/qat_dh895xcc/adf_drv.c | 9 ++-------
drivers/crypto/qat/qat_dh895xccvf/adf_drv.c | 9 ++-------
7 files changed, 14 insertions(+), 48 deletions(-)
diff --git a/drivers/crypto/qat/qat_4xxx/adf_drv.c b/drivers/crypto/qat/qat_4xxx/adf_drv.c
index a8805c815d16..f2b6c0ca039a 100644
--- a/drivers/crypto/qat/qat_4xxx/adf_drv.c
+++ b/drivers/crypto/qat/qat_4xxx/adf_drv.c
@@ -221,16 +221,12 @@ static int adf_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
}
/* Set DMA identifier */
- if (pci_set_dma_mask(pdev, DMA_BIT_MASK(64))) {
- if ((pci_set_dma_mask(pdev, DMA_BIT_MASK(32)))) {
+ if (dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(64))) {
+ if ((dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(32)))) {
dev_err(&pdev->dev, "No usable DMA configuration.\n");
ret = -EFAULT;
goto out_err;
- } else {
- pci_set_consistent_dma_mask(pdev, DMA_BIT_MASK(32));
}
- } else {
- pci_set_consistent_dma_mask(pdev, DMA_BIT_MASK(64));
}
/* Get accelerator capabilities mask */
diff --git a/drivers/crypto/qat/qat_c3xxx/adf_drv.c b/drivers/crypto/qat/qat_c3xxx/adf_drv.c
index 7fb3343ae8b0..cc4ed61478a8 100644
--- a/drivers/crypto/qat/qat_c3xxx/adf_drv.c
+++ b/drivers/crypto/qat/qat_c3xxx/adf_drv.c
@@ -159,17 +159,12 @@ static int adf_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
}
/* set dma identifier */
- if (pci_set_dma_mask(pdev, DMA_BIT_MASK(64))) {
- if ((pci_set_dma_mask(pdev, DMA_BIT_MASK(32)))) {
+ if (dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(64))) {
+ if ((dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(32)))) {
dev_err(&pdev->dev, "No usable DMA configuration\n");
ret = -EFAULT;
goto out_err_disable;
- } else {
- pci_set_consistent_dma_mask(pdev, DMA_BIT_MASK(32));
}
-
- } else {
- pci_set_consistent_dma_mask(pdev, DMA_BIT_MASK(64));
}
if (pci_request_regions(pdev, ADF_C3XXX_DEVICE_NAME)) {
diff --git a/drivers/crypto/qat/qat_c3xxxvf/adf_drv.c b/drivers/crypto/qat/qat_c3xxxvf/adf_drv.c
index 067ca5e17d38..e271da064266 100644
--- a/drivers/crypto/qat/qat_c3xxxvf/adf_drv.c
+++ b/drivers/crypto/qat/qat_c3xxxvf/adf_drv.c
@@ -141,17 +141,12 @@ static int adf_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
}
/* set dma identifier */
- if (pci_set_dma_mask(pdev, DMA_BIT_MASK(64))) {
- if ((pci_set_dma_mask(pdev, DMA_BIT_MASK(32)))) {
+ if (dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(64))) {
+ if ((dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(32)))) {
dev_err(&pdev->dev, "No usable DMA configuration\n");
ret = -EFAULT;
goto out_err_disable;
- } else {
- pci_set_consistent_dma_mask(pdev, DMA_BIT_MASK(32));
}
-
- } else {
- pci_set_consistent_dma_mask(pdev, DMA_BIT_MASK(64));
}
if (pci_request_regions(pdev, ADF_C3XXXVF_DEVICE_NAME)) {
diff --git a/drivers/crypto/qat/qat_c62x/adf_drv.c b/drivers/crypto/qat/qat_c62x/adf_drv.c
index 1f5de442e1e6..5e2fc0c1a759 100644
--- a/drivers/crypto/qat/qat_c62x/adf_drv.c
+++ b/drivers/crypto/qat/qat_c62x/adf_drv.c
@@ -159,17 +159,12 @@ static int adf_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
}
/* set dma identifier */
- if (pci_set_dma_mask(pdev, DMA_BIT_MASK(64))) {
- if ((pci_set_dma_mask(pdev, DMA_BIT_MASK(32)))) {
+ if (dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(64))) {
+ if ((dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(32)))) {
dev_err(&pdev->dev, "No usable DMA configuration\n");
ret = -EFAULT;
goto out_err_disable;
- } else {
- pci_set_consistent_dma_mask(pdev, DMA_BIT_MASK(32));
}
-
- } else {
- pci_set_consistent_dma_mask(pdev, DMA_BIT_MASK(64));
}
if (pci_request_regions(pdev, ADF_C62X_DEVICE_NAME)) {
diff --git a/drivers/crypto/qat/qat_c62xvf/adf_drv.c b/drivers/crypto/qat/qat_c62xvf/adf_drv.c
index 51ea88c0b17d..8fa5660fe654 100644
--- a/drivers/crypto/qat/qat_c62xvf/adf_drv.c
+++ b/drivers/crypto/qat/qat_c62xvf/adf_drv.c
@@ -141,17 +141,12 @@ static int adf_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
}
/* set dma identifier */
- if (pci_set_dma_mask(pdev, DMA_BIT_MASK(64))) {
- if ((pci_set_dma_mask(pdev, DMA_BIT_MASK(32)))) {
+ if (dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(64))) {
+ if ((dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(32)))) {
dev_err(&pdev->dev, "No usable DMA configuration\n");
ret = -EFAULT;
goto out_err_disable;
- } else {
- pci_set_consistent_dma_mask(pdev, DMA_BIT_MASK(32));
}
-
- } else {
- pci_set_consistent_dma_mask(pdev, DMA_BIT_MASK(64));
}
if (pci_request_regions(pdev, ADF_C62XVF_DEVICE_NAME)) {
diff --git a/drivers/crypto/qat/qat_dh895xcc/adf_drv.c b/drivers/crypto/qat/qat_dh895xcc/adf_drv.c
index a9ec4357144c..d0bd18e65104 100644
--- a/drivers/crypto/qat/qat_dh895xcc/adf_drv.c
+++ b/drivers/crypto/qat/qat_dh895xcc/adf_drv.c
@@ -159,17 +159,12 @@ static int adf_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
}
/* set dma identifier */
- if (pci_set_dma_mask(pdev, DMA_BIT_MASK(64))) {
- if ((pci_set_dma_mask(pdev, DMA_BIT_MASK(32)))) {
+ if (dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(64))) {
+ if ((dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(32)))) {
dev_err(&pdev->dev, "No usable DMA configuration\n");
ret = -EFAULT;
goto out_err_disable;
- } else {
- pci_set_consistent_dma_mask(pdev, DMA_BIT_MASK(32));
}
-
- } else {
- pci_set_consistent_dma_mask(pdev, DMA_BIT_MASK(64));
}
if (pci_request_regions(pdev, ADF_DH895XCC_DEVICE_NAME)) {
diff --git a/drivers/crypto/qat/qat_dh895xccvf/adf_drv.c b/drivers/crypto/qat/qat_dh895xccvf/adf_drv.c
index 29999da716cc..ce5eab45218e 100644
--- a/drivers/crypto/qat/qat_dh895xccvf/adf_drv.c
+++ b/drivers/crypto/qat/qat_dh895xccvf/adf_drv.c
@@ -141,17 +141,12 @@ static int adf_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
}
/* set dma identifier */
- if (pci_set_dma_mask(pdev, DMA_BIT_MASK(64))) {
- if ((pci_set_dma_mask(pdev, DMA_BIT_MASK(32)))) {
+ if (dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(64))) {
+ if ((dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(32)))) {
dev_err(&pdev->dev, "No usable DMA configuration\n");
ret = -EFAULT;
goto out_err_disable;
- } else {
- pci_set_consistent_dma_mask(pdev, DMA_BIT_MASK(32));
}
-
- } else {
- pci_set_consistent_dma_mask(pdev, DMA_BIT_MASK(64));
}
if (pci_request_regions(pdev, ADF_DH895XCCVF_DEVICE_NAME)) {
--
2.30.2
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 2/3] crypto: qat - Disable AER if an error occurs in probe functions
2021-07-11 6:12 [PATCH 0/3] crypto: qat - Fixes and clean-ups Christophe JAILLET
2021-07-11 6:13 ` [PATCH 1/3] crypto: qat - Simplify code and axe the use of a deprecated API Christophe JAILLET
@ 2021-07-11 6:13 ` Christophe JAILLET
2021-07-11 6:13 ` [PATCH 3/3] crypto: qat - Fix a typo in a comment Christophe JAILLET
2021-07-12 10:28 ` [PATCH 0/3] crypto: qat - Fixes and clean-ups Andy Shevchenko
3 siblings, 0 replies; 6+ messages in thread
From: Christophe JAILLET @ 2021-07-11 6:13 UTC (permalink / raw)
To: giovanni.cabiddu, herbert, davem, tomaszx.kowalik,
marco.chiappero, andriy.shevchenko, fiona.trahe, wojciech.ziemba,
ztong0001, qat-linux
Cc: linux-crypto, linux-kernel, kernel-janitors, Christophe JAILLET
If an error occurs after a 'adf_enable_aer()' call, it must be undone by a
corresponding 'adf_disable_aer()' call, as already done in the remove
function.
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
drivers/crypto/qat/qat_c3xxx/adf_drv.c | 6 ++++--
drivers/crypto/qat/qat_c62x/adf_drv.c | 6 ++++--
drivers/crypto/qat/qat_dh895xcc/adf_drv.c | 6 ++++--
3 files changed, 12 insertions(+), 6 deletions(-)
diff --git a/drivers/crypto/qat/qat_c3xxx/adf_drv.c b/drivers/crypto/qat/qat_c3xxx/adf_drv.c
index cc4ed61478a8..aa5078177e5d 100644
--- a/drivers/crypto/qat/qat_c3xxx/adf_drv.c
+++ b/drivers/crypto/qat/qat_c3xxx/adf_drv.c
@@ -203,12 +203,12 @@ static int adf_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
if (pci_save_state(pdev)) {
dev_err(&pdev->dev, "Failed to save pci state\n");
ret = -ENOMEM;
- goto out_err_free_reg;
+ goto out_err_disable_aer;
}
ret = qat_crypto_dev_config(accel_dev);
if (ret)
- goto out_err_free_reg;
+ goto out_err_disable_aer;
ret = adf_dev_init(accel_dev);
if (ret)
@@ -224,6 +224,8 @@ static int adf_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
adf_dev_stop(accel_dev);
out_err_dev_shutdown:
adf_dev_shutdown(accel_dev);
+out_err_disable_aer:
+ adf_disable_aer(accel_dev);
out_err_free_reg:
pci_release_regions(accel_pci_dev->pci_dev);
out_err_disable:
diff --git a/drivers/crypto/qat/qat_c62x/adf_drv.c b/drivers/crypto/qat/qat_c62x/adf_drv.c
index 5e2fc0c1a759..54ab8291be73 100644
--- a/drivers/crypto/qat/qat_c62x/adf_drv.c
+++ b/drivers/crypto/qat/qat_c62x/adf_drv.c
@@ -203,12 +203,12 @@ static int adf_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
if (pci_save_state(pdev)) {
dev_err(&pdev->dev, "Failed to save pci state\n");
ret = -ENOMEM;
- goto out_err_free_reg;
+ goto out_err_disable_aer;
}
ret = qat_crypto_dev_config(accel_dev);
if (ret)
- goto out_err_free_reg;
+ goto out_err_disable_aer;
ret = adf_dev_init(accel_dev);
if (ret)
@@ -224,6 +224,8 @@ static int adf_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
adf_dev_stop(accel_dev);
out_err_dev_shutdown:
adf_dev_shutdown(accel_dev);
+out_err_disable_aer:
+ adf_disable_aer(accel_dev);
out_err_free_reg:
pci_release_regions(accel_pci_dev->pci_dev);
out_err_disable:
diff --git a/drivers/crypto/qat/qat_dh895xcc/adf_drv.c b/drivers/crypto/qat/qat_dh895xcc/adf_drv.c
index d0bd18e65104..507663bc5d54 100644
--- a/drivers/crypto/qat/qat_dh895xcc/adf_drv.c
+++ b/drivers/crypto/qat/qat_dh895xcc/adf_drv.c
@@ -203,12 +203,12 @@ static int adf_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
if (pci_save_state(pdev)) {
dev_err(&pdev->dev, "Failed to save pci state\n");
ret = -ENOMEM;
- goto out_err_free_reg;
+ goto out_err_disable_aer;
}
ret = qat_crypto_dev_config(accel_dev);
if (ret)
- goto out_err_free_reg;
+ goto out_err_disable_aer;
ret = adf_dev_init(accel_dev);
if (ret)
@@ -224,6 +224,8 @@ static int adf_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
adf_dev_stop(accel_dev);
out_err_dev_shutdown:
adf_dev_shutdown(accel_dev);
+out_err_disable_aer:
+ adf_disable_aer(accel_dev);
out_err_free_reg:
pci_release_regions(accel_pci_dev->pci_dev);
out_err_disable:
--
2.30.2
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 3/3] crypto: qat - Fix a typo in a comment
2021-07-11 6:12 [PATCH 0/3] crypto: qat - Fixes and clean-ups Christophe JAILLET
2021-07-11 6:13 ` [PATCH 1/3] crypto: qat - Simplify code and axe the use of a deprecated API Christophe JAILLET
2021-07-11 6:13 ` [PATCH 2/3] crypto: qat - Disable AER if an error occurs in probe functions Christophe JAILLET
@ 2021-07-11 6:13 ` Christophe JAILLET
2021-07-12 10:28 ` [PATCH 0/3] crypto: qat - Fixes and clean-ups Andy Shevchenko
3 siblings, 0 replies; 6+ messages in thread
From: Christophe JAILLET @ 2021-07-11 6:13 UTC (permalink / raw)
To: giovanni.cabiddu, herbert, davem, tomaszx.kowalik,
marco.chiappero, andriy.shevchenko, fiona.trahe, wojciech.ziemba,
ztong0001, qat-linux
Cc: linux-crypto, linux-kernel, kernel-janitors, Christophe JAILLET
s/Enable/Disable/ when describing 'adf_disable_aer()'
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
drivers/crypto/qat/qat_common/adf_aer.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/crypto/qat/qat_common/adf_aer.c b/drivers/crypto/qat/qat_common/adf_aer.c
index d2ae293d0df6..ed3e40bc56eb 100644
--- a/drivers/crypto/qat/qat_common/adf_aer.c
+++ b/drivers/crypto/qat/qat_common/adf_aer.c
@@ -194,7 +194,7 @@ int adf_enable_aer(struct adf_accel_dev *accel_dev)
EXPORT_SYMBOL_GPL(adf_enable_aer);
/**
- * adf_disable_aer() - Enable Advance Error Reporting for acceleration device
+ * adf_disable_aer() - Disable Advance Error Reporting for acceleration device
* @accel_dev: Pointer to acceleration device.
*
* Function disables PCI Advance Error Reporting for the
--
2.30.2
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 1/3] crypto: qat - Simplify code and axe the use of a deprecated API
2021-07-11 6:13 ` [PATCH 1/3] crypto: qat - Simplify code and axe the use of a deprecated API Christophe JAILLET
@ 2021-07-12 10:20 ` Andy Shevchenko
0 siblings, 0 replies; 6+ messages in thread
From: Andy Shevchenko @ 2021-07-12 10:20 UTC (permalink / raw)
To: Christophe JAILLET
Cc: giovanni.cabiddu, herbert, davem, tomaszx.kowalik,
marco.chiappero, fiona.trahe, wojciech.ziemba, ztong0001,
qat-linux, linux-crypto, linux-kernel, kernel-janitors
On Sun, Jul 11, 2021 at 08:13:18AM +0200, Christophe JAILLET wrote:
> The wrappers in include/linux/pci-dma-compat.h should go away.
>
> Replace 'pci_set_dma_mask/pci_set_consistent_dma_mask' by an equivalent
> and less verbose 'dma_set_mask_and_coherent()' call.
> If needed, see post from Christoph Hellwig on the kernel-janitors ML:
> https://marc.info/?l=kernel-janitors&m=158745678307186&w=4
See his another (recent) mail here: https://www.spinics.net/lists/kernel/msg3967232.html...
> + if (dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(64))) {
> + if ((dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(32)))) {
...and drop this part from all entries completely.
> + if (dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(64))) {
> + if ((dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(32)))) {
> + if (dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(64))) {
> + if ((dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(32)))) {
> + if (dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(64))) {
> + if ((dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(32)))) {
> + if (dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(64))) {
> + if ((dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(32)))) {
> + if (dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(64))) {
> + if ((dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(32)))) {
> + if (dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(64))) {
> + if ((dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(32)))) {
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 0/3] crypto: qat - Fixes and clean-ups
2021-07-11 6:12 [PATCH 0/3] crypto: qat - Fixes and clean-ups Christophe JAILLET
` (2 preceding siblings ...)
2021-07-11 6:13 ` [PATCH 3/3] crypto: qat - Fix a typo in a comment Christophe JAILLET
@ 2021-07-12 10:28 ` Andy Shevchenko
3 siblings, 0 replies; 6+ messages in thread
From: Andy Shevchenko @ 2021-07-12 10:28 UTC (permalink / raw)
To: Christophe JAILLET
Cc: giovanni.cabiddu, herbert, davem, tomaszx.kowalik,
marco.chiappero, fiona.trahe, wojciech.ziemba, ztong0001,
qat-linux, linux-crypto, linux-kernel, kernel-janitors
On Sun, Jul 11, 2021 at 08:12:57AM +0200, Christophe JAILLET wrote:
> The only link between these 3 patches are that they are all related to
> 'drivers/crypto/qat'.
Entire series looks good after addressing comment against patch 1.
Feel free to add
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Christophe JAILLET (3):
> crypto: qat - Simplify code and axe the use of a deprecated API
> crypto: qat - Disable AER if an error occurs in probe functions
> crypto: qat - Fix a typo in a comment
>
> drivers/crypto/qat/qat_4xxx/adf_drv.c | 8 ++------
> drivers/crypto/qat/qat_c3xxx/adf_drv.c | 15 ++++++---------
> drivers/crypto/qat/qat_c3xxxvf/adf_drv.c | 9 ++-------
> drivers/crypto/qat/qat_c62x/adf_drv.c | 15 ++++++---------
> drivers/crypto/qat/qat_c62xvf/adf_drv.c | 9 ++-------
> drivers/crypto/qat/qat_common/adf_aer.c | 2 +-
> drivers/crypto/qat/qat_dh895xcc/adf_drv.c | 15 ++++++---------
> drivers/crypto/qat/qat_dh895xccvf/adf_drv.c | 9 ++-------
> 8 files changed, 27 insertions(+), 55 deletions(-)
>
> --
> 2.30.2
>
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-07-12 10:28 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-11 6:12 [PATCH 0/3] crypto: qat - Fixes and clean-ups Christophe JAILLET
2021-07-11 6:13 ` [PATCH 1/3] crypto: qat - Simplify code and axe the use of a deprecated API Christophe JAILLET
2021-07-12 10:20 ` Andy Shevchenko
2021-07-11 6:13 ` [PATCH 2/3] crypto: qat - Disable AER if an error occurs in probe functions Christophe JAILLET
2021-07-11 6:13 ` [PATCH 3/3] crypto: qat - Fix a typo in a comment Christophe JAILLET
2021-07-12 10:28 ` [PATCH 0/3] crypto: qat - Fixes and clean-ups Andy Shevchenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).