From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1946C07E9B for ; Mon, 19 Jul 2021 17:04:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6D12360E0C for ; Mon, 19 Jul 2021 17:04:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347741AbhGSQXs (ORCPT ); Mon, 19 Jul 2021 12:23:48 -0400 Received: from smtp06.smtpout.orange.fr ([80.12.242.128]:19578 "EHLO smtp.smtpout.orange.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1349685AbhGSQVp (ORCPT ); Mon, 19 Jul 2021 12:21:45 -0400 Received: from localhost.localdomain ([80.15.159.30]) by mwinf5d82 with ME id X52H2500Q0feRjk0352JKU; Mon, 19 Jul 2021 19:02:19 +0200 X-ME-Helo: localhost.localdomain X-ME-Auth: Y2hyaXN0b3BoZS5qYWlsbGV0QHdhbmFkb28uZnI= X-ME-Date: Mon, 19 Jul 2021 19:02:19 +0200 X-ME-IP: 80.15.159.30 From: Christophe JAILLET To: mustafa.ismail@intel.com, shiraz.saleem@intel.com, dledford@redhat.com, jgg@ziepe.ca Cc: linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Christophe JAILLET Subject: [PATCH] RDMA/irdma: Improve the way 'cqp_request' structures are cleaned when they are recycled Date: Mon, 19 Jul 2021 19:02:15 +0200 Message-Id: <7f93f2a2c2fd18ddfeb99339d175b85ffd1c6398.1626713915.git.christophe.jaillet@wanadoo.fr> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: kernel-janitors@vger.kernel.org A set of IRDMA_CQP_SW_SQSIZE_2048 (i.e. 2048) 'cqp_request' are pre-allocated and zeroed in 'irdma_create_cqp()' (hw.c). These structures are managed with the 'cqp->cqp_avail_reqs' list which keeps track of available entries. In 'irdma_free_cqp_request()' (utils.c), when an entry is recycled and goes back to the 'cqp_avail_reqs' list, some fields are reseted. However, one of these fields, 'compl_info', is initialized within 'irdma_alloc_and_get_cqp_request()'. Move the corresponding memset to 'irdma_free_cqp_request()' so that the clean-up is done in only one place. This makes the logic more easy to understand. This also saves this memset in the case that the 'cqp_avail_reqs' list is empty and a new 'cqp_request' structure must be allocated. This memset is useless, because the structure is already kzalloc'ed. Signed-off-by: Christophe JAILLET --- drivers/infiniband/hw/irdma/utils.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/infiniband/hw/irdma/utils.c b/drivers/infiniband/hw/irdma/utils.c index 5bbe44e54f9a..66711024d38b 100644 --- a/drivers/infiniband/hw/irdma/utils.c +++ b/drivers/infiniband/hw/irdma/utils.c @@ -445,7 +445,6 @@ struct irdma_cqp_request *irdma_alloc_and_get_cqp_request(struct irdma_cqp *cqp, cqp_request->waiting = wait; refcount_set(&cqp_request->refcnt, 1); - memset(&cqp_request->compl_info, 0, sizeof(cqp_request->compl_info)); return cqp_request; } @@ -475,6 +474,7 @@ void irdma_free_cqp_request(struct irdma_cqp *cqp, cqp_request->request_done = false; cqp_request->callback_fcn = NULL; cqp_request->waiting = false; + memset(&cqp_request->compl_info, 0, sizeof(cqp_request->compl_info)); spin_lock_irqsave(&cqp->req_lock, flags); list_add_tail(&cqp_request->list, &cqp->cqp_avail_reqs); -- 2.30.2