From: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Hans de Goede <hdegoede@redhat.com>,
Mark Gross <mgross@linux.intel.com>,
platform-driver-x86@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] platform/x86: ISST: use semi-colons instead of commas
Date: Wed, 25 Aug 2021 04:02:48 -0700 [thread overview]
Message-ID: <805eaf49531f38c28f0caf12cc9d0afafd98f7a5.camel@linux.intel.com> (raw)
In-Reply-To: <20210825072357.GA12957@kili>
On Wed, 2021-08-25 at 10:23 +0300, Dan Carpenter wrote:
> The code works the same either way, but it's better to use semi-
> colons
> to separate statements.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
> ---
> drivers/platform/x86/intel_speed_select_if/isst_if_common.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git
> a/drivers/platform/x86/intel_speed_select_if/isst_if_common.c
> b/drivers/platform/x86/intel_speed_select_if/isst_if_common.c
> index 8a4d52a9028d..c9a85eb2e860 100644
> --- a/drivers/platform/x86/intel_speed_select_if/isst_if_common.c
> +++ b/drivers/platform/x86/intel_speed_select_if/isst_if_common.c
> @@ -265,9 +265,9 @@ static int isst_if_get_platform_info(void __user
> *argp)
> {
> struct isst_if_platform_info info;
>
> - info.api_version = ISST_IF_API_VERSION,
> - info.driver_version = ISST_IF_DRIVER_VERSION,
> - info.max_cmds_per_ioctl = ISST_IF_CMD_LIMIT,
> + info.api_version = ISST_IF_API_VERSION;
> + info.driver_version = ISST_IF_DRIVER_VERSION;
> + info.max_cmds_per_ioctl = ISST_IF_CMD_LIMIT;
> info.mbox_supported =
> punit_callbacks[ISST_IF_DEV_MBOX].registered;
> info.mmio_supported =
> punit_callbacks[ISST_IF_DEV_MMIO].registered;
>
next prev parent reply other threads:[~2021-08-25 11:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-25 7:23 [PATCH] platform/x86: ISST: use semi-colons instead of commas Dan Carpenter
2021-08-25 11:02 ` Srinivas Pandruvada [this message]
2021-08-26 13:18 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=805eaf49531f38c28f0caf12cc9d0afafd98f7a5.camel@linux.intel.com \
--to=srinivas.pandruvada@linux.intel.com \
--cc=dan.carpenter@oracle.com \
--cc=hdegoede@redhat.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=mgross@linux.intel.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).