From: Hans Verkuil <hverkuil@xs4all.nl>
To: Colin Ian King <colin.king@canonical.com>,
Mike Isely <isely@pobox.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-media@vger.kernel.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: NAK: [PATCH][next] media: pvrusb2: add newline between two statements
Date: Mon, 13 Sep 2021 13:00:54 +0200 [thread overview]
Message-ID: <82d125bd-9d16-803d-754b-48aa79fde06c@xs4all.nl> (raw)
In-Reply-To: <52c324ad-2467-9edc-c386-bc5a086cecbc@canonical.com>
On 03/09/2021 00:02, Colin Ian King wrote:
> On 02/09/2021 23:01, Colin King wrote:
>> From: Colin Ian King <colin.king@canonical.com>
>>
>> There are two statements on the same line, add a newline to clean
>> this up.
>>
>> Signed-off-by: Colin Ian King <colin.king@canonical.com>
>> ---
>> drivers/media/usb/pvrusb2/pvrusb2-hdw.c | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/media/usb/pvrusb2/pvrusb2-hdw.c b/drivers/media/usb/pvrusb2/pvrusb2-hdw.c
>> index d38dee1792e4..ca00b7fe1e7f 100644
>> --- a/drivers/media/usb/pvrusb2/pvrusb2-hdw.c
>> +++ b/drivers/media/usb/pvrusb2/pvrusb2-hdw.c
>> @@ -1727,7 +1727,8 @@ int pvr2_hdw_set_streaming(struct pvr2_hdw *hdw,int enable_flag)
>> enable_flag ? "enable" : "disable");
>> }
>> pvr2_hdw_state_sched(hdw);
>> - } while (0); LOCK_GIVE(hdw->big_lock);
>> + } while (0);
>> + LOCK_GIVE(hdw->big_lock);
>> if ((ret = pvr2_hdw_wait(hdw,0)) < 0) return ret;
>> if (enable_flag) {
>> while ((st = hdw->master_state) != PVR2_STATE_RUN) {
>>
>
> ignore, V2 being sent in a moment.
I haven't seen a V2 yet... In any case, I've rejected this patch in patchwork.
Regards,
Hans
next prev parent reply other threads:[~2021-09-13 11:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-02 22:01 [PATCH][next] media: pvrusb2: add newline between two statements Colin King
2021-09-02 22:02 ` NAK: " Colin Ian King
2021-09-13 11:00 ` Hans Verkuil [this message]
2021-09-13 11:04 ` Colin Ian King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=82d125bd-9d16-803d-754b-48aa79fde06c@xs4all.nl \
--to=hverkuil@xs4all.nl \
--cc=colin.king@canonical.com \
--cc=isely@pobox.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).