From: Jeff Layton <jlayton@kernel.org>
To: Colin King <colin.king@canonical.com>,
Ilya Dryomov <idryomov@gmail.com>,
ceph-devel@vger.kernel.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ceph: remove redundant initialization of variable mds
Date: Thu, 23 Jul 2020 17:24:11 +0000 [thread overview]
Message-ID: <853430a6bb4216a5e4a0d734a18b8401b89e7f4b.camel@kernel.org> (raw)
In-Reply-To: <20200723152240.992946-1-colin.king@canonical.com>
On Thu, 2020-07-23 at 16:22 +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The variable mds is being initialized with a value that is never read
> and it is being updated later with a new value. The initialization is
> redundant and can be removed.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> fs/ceph/debugfs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/ceph/debugfs.c b/fs/ceph/debugfs.c
> index 070ed8481340..48f5afb56c91 100644
> --- a/fs/ceph/debugfs.c
> +++ b/fs/ceph/debugfs.c
> @@ -272,7 +272,7 @@ static int mds_sessions_show(struct seq_file *s, void *ptr)
> struct ceph_mds_client *mdsc = fsc->mdsc;
> struct ceph_auth_client *ac = fsc->client->monc.auth;
> struct ceph_options *opt = fsc->client->options;
> - int mds = -1;
> + int mds;
>
> mutex_lock(&mdsc->mutex);
>
Thanks, merged into testing branch.
--
Jeff Layton <jlayton@kernel.org>
prev parent reply other threads:[~2020-07-23 17:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-23 15:22 [PATCH] ceph: remove redundant initialization of variable mds Colin King
2020-07-23 17:24 ` Jeff Layton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=853430a6bb4216a5e4a0d734a18b8401b89e7f4b.camel@kernel.org \
--to=jlayton@kernel.org \
--cc=ceph-devel@vger.kernel.org \
--cc=colin.king@canonical.com \
--cc=idryomov@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).