kernel-janitors.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tiezhu Yang <yangtiezhu@loongson.cn>
To: Markus Elfring <Markus.Elfring@web.de>,
	Thomas Gleixner <tglx@linutronix.de>,
	Jason Cooper <jason@lakedaemon.net>,
	Marc Zyngier <maz@kernel.org>, Guo Ren <guoren@kernel.org>,
	linux-csky@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [v4 02/14] irqchip/csky-apb-intc: Fix potential resource leaks
Date: Thu, 02 Jul 2020 12:35:58 +0000	[thread overview]
Message-ID: <856f5c62-d731-fc3c-0e41-0c2d8b4e24a3@loongson.cn> (raw)
In-Reply-To: <14cacb4e-d687-dfc4-8ad8-26f9f1050a0e@web.de>

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="windows-1254", Size: 782 bytes --]

On 07/02/2020 08:24 PM, Markus Elfring wrote:
>>>>>>> +++ b/drivers/irqchip/irq-csky-apb-intc.c
> …
>> Let us keep it as it is
> I propose to reconsider also this view.
>
>
>> to make the code clear and to avoid the alignment issue:
>>
>> ret = foo();
>> if (ret) {
>>          ret = -ENOMEM;
> How do you think about to delete this assignment if you would like to
> reuse the return value from a call of the function “irq_alloc_domain_generic_chips”?

OK, looks good to me, thank you.

>
>
>>          goto ...
>> }
>
> Please apply a known script also for the purpose to achieve consistent indentation.
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/scripts/checkpatch.pl?idÍ77006e01b3198c75fb7819b3d0ff89709539bb#n3301

OK

>
> Regards,
> Markus

  reply	other threads:[~2020-07-02 12:35 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1593569786-11500-1-git-send-email-yangtiezhu@loongson.cn>
     [not found] ` <1593569786-11500-4-git-send-email-yangtiezhu@loongson.cn>
2020-07-01  7:49   ` [PATCH v4 03/14] irqchip/csky-mpintc: " Markus Elfring
2020-07-01  9:23     ` Tiezhu Yang
     [not found] ` <1593569786-11500-5-git-send-email-yangtiezhu@loongson.cn>
2020-07-01  8:15   ` [PATCH v4 04/14] irqchip/davinci-aintc: " Markus Elfring
2020-07-01  9:19     ` Tiezhu Yang
     [not found] ` <1593569786-11500-3-git-send-email-yangtiezhu@loongson.cn>
2020-07-01  8:40   ` [PATCH v4 02/14] irqchip/csky-apb-intc: " Markus Elfring
2020-07-01  9:35     ` Tiezhu Yang
2020-07-01 13:04       ` Markus Elfring
2020-07-02  1:18         ` Tiezhu Yang
2020-07-02  7:19           ` Markus Elfring
2020-07-02  7:19           ` Markus Elfring
2020-07-02  8:05             ` Tiezhu Yang
2020-07-02 11:53               ` Tiezhu Yang
2020-07-02 12:24                 ` [v4 " Markus Elfring
2020-07-02 12:35                   ` Tiezhu Yang [this message]
2020-07-02 15:00       ` [PATCH v4 " Dan Carpenter
     [not found] ` <1593569786-11500-12-git-send-email-yangtiezhu@loongson.cn>
2020-07-01  9:14   ` [PATCH v4 11/14] irqchip/omap-intc: Fix potential resource leak Markus Elfring
2020-07-01  9:40     ` Tiezhu Yang
     [not found] ` <1593569786-11500-13-git-send-email-yangtiezhu@loongson.cn>
2020-07-01  9:30   ` [PATCH v4 12/14] irqchip/riscv-intc: " Markus Elfring
     [not found] ` <1593569786-11500-15-git-send-email-yangtiezhu@loongson.cn>
2020-07-01  9:42   ` [PATCH v4 14/14] irqchip/xilinx-intc: " Markus Elfring
2020-07-01  9:58     ` Tiezhu Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=856f5c62-d731-fc3c-0e41-0c2d8b4e24a3@loongson.cn \
    --to=yangtiezhu@loongson.cn \
    --cc=Markus.Elfring@web.de \
    --cc=guoren@kernel.org \
    --cc=jason@lakedaemon.net \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-csky@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maz@kernel.org \
    --cc=tglx@linutronix.de \
    --subject='Re: [v4 02/14] irqchip/csky-apb-intc: Fix potential resource leaks' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).