From: Randy Dunlap <rdunlap@infradead.org>
To: kernel-janitors@vger.kernel.org
Subject: Re: [help][coccinelle] coccicheck failed
Date: Thu, 18 Jun 2020 17:19:57 +0000 [thread overview]
Message-ID: <86fca9ee-4926-af6e-1d3b-da1e7a6ca3c9@infradead.org> (raw)
In-Reply-To: <47cba5b5-0d49-f6e8-09db-557a4c15f285@gmail.com>
On 6/18/20 9:45 AM, Giacomo Picchiarelli wrote:
> make coccicheck MODE=patch DEBUG_FILE=cocci3.err
>
> result:
>
> /usr/local/bin/spatch -D patch --very-quiet --cocci-file ./scripts/coccinelle/api/alloc/alloc_cast.cocci --no-includes --include-headers --dir . -I ./arch/x86/include -I ./arch/x86/include/generated -I ./include -I ./arch/x86/include/uapi -I ./arch/x86/include/generated/uapi -I ./include/uapi -I ./include/generated/uapi --include ./include/linux/kconfig.h --jobs 8 --chunksize 1
>
> Python error: No module named coccilib.elems
>
> Suggestions? Missing something?
>
It's looking in the wrong location for the library files.
(We went thru this just last week.)
This is what fixed it for me:
$ cd /usr/local/lib
$ sudo ln ../lib64/coccinelle coccinelle
so that spatch can find the library file(s) in /usr/local/lib64
instead of in /usr/local/lib.
>
> On 18/06/20 17:23, Julia Lawall wrote:
>>
>> On Thu, 18 Jun 2020, Giacomo Picchiarelli wrote:
>>
>>> Newbie here. I couldn't try the patch attached.
>> Hi,
>>
>> I'm not sure what you are trying to do. The patch attached is a real
>> patch, not a Coccinelle semantic patch.
>>
>>> I'm using coccinelle (spatch version 1.0.4 with Python support and with PCRE support),
>>> I'm having issues with the following command:
>>>
>>> make coccicheck MODE=patch
>>>
>>> "./tools/testing/selftests/net/hwtstamp_config.c:74:45-46: WARNING: Use ARRAY_SIZE
>>>
>>> 807 811
>>>
>>> coccicheck failed"
>> Randy's suggestion about DEBUG is good. You can also get a more modern
>> version of Coccinelle from github.
>>
>> julia
>
> Hi Julia,
> I'm actually having some issues with coccinelle compilation, I'm going to try with the newest version as soon as possible.
> Thanks.
>
>>
>>
>>> Applied to: commit 1b5044021070efa3259f3e9548dc35d1eb6aa844 (HEAD -> master, origin/master, origin/HEAD)
>>> Merge: 69119673bd50 dbed452a078d
>>> Author: Linus Torvalds <torvalds@linux-foundation.org>
>>> Date: Wed Jun 17 11:29:37 2020 -0700
>>>
>>> Suggestions?
>>>
>>> --
>>> Giacomo Picchiarelli <gpicchiarelli@gmail.com>
>>> GPG Key: 2E51 2591 F3E8 7CDC F504 140F 8559 3ACF 4691 ACC0
>>>
>>>
--
~Randy
Reported-by: Randy Dunlap <rdunlap@infradead.org>
prev parent reply other threads:[~2020-06-18 17:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-18 13:23 [help][coccinelle] coccicheck failed Giacomo Picchiarelli
2020-06-18 15:07 ` Randy Dunlap
2020-06-18 15:23 ` Julia Lawall
2020-06-18 16:45 ` Giacomo Picchiarelli
2020-06-18 17:19 ` Randy Dunlap [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86fca9ee-4926-af6e-1d3b-da1e7a6ca3c9@infradead.org \
--to=rdunlap@infradead.org \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).