From mboxrd@z Thu Jan 1 00:00:00 1970 From: OGAWA Hirofumi Date: Sat, 29 Nov 2014 10:44:11 +0000 Subject: Re: [PATCH v2] fs-fat: Less function calls in fat_fill_super() after error detection Message-Id: <87sih22sn8.fsf@devron.myhome.or.jp> List-Id: References: <5307CAA2.8060406@users.sourceforge.net> <530A086E.8010901@users.sourceforge.net> <530A72AA.3000601@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> <5467B12C.4010602@users.sourceforge.net> <54796B5E.5040707@users.sourceforge.net> In-Reply-To: <54796B5E.5040707@users.sourceforge.net> (SF Markus Elfring's message of "Sat, 29 Nov 2014 07:44:46 +0100") MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: SF Markus Elfring Cc: Julia Lawall , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, trivial@kernel.org, Coccinelle SF Markus Elfring writes: > From: Markus Elfring > Date: Sat, 29 Nov 2014 07:37:34 +0100 > > The iput() function was called in an inefficient way by the implementation > of the fat_fill_super() function in case of an allocation failure. > The corresponding source code was improved by deletion of two unnecessary > null pointer checks and a few adjustments for jump labels. iput() checks NULL of inode. What is wrong just remove NULL check, instead of adding new jump labels? Thanks. -- OGAWA Hirofumi