From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Gleixner Date: Thu, 24 Sep 2020 20:19:03 +0000 Subject: Re: [Cocci] coccinelle: Convert comma to semicolons (was Re: [PATCH] checkpatch: Add test for comma Message-Id: <87tuvn6i88.fsf@nanos.tec.linutronix.de> List-Id: References: <20200818184107.f8af232fb58b17160c570874@linux-foundation.org> <3bf27caf462007dfa75647b040ab3191374a59de.camel@perches.com> <744af177c09f8ce22c99d6e1df458bced558518b.camel@perches.com> <162653.1598067338@turing-police> <3836b482434bd0b9a609959d3696cc6113a93f2f.camel@perches.com> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Julia Lawall , Joe Perches Cc: Giuseppe Scrivano , Valdis =?utf-8?Q?Kl=C4=93tnieks?= , kernelnewbies , kernel-janitors , LKML , Andy Whitcroft , Andrew Morton , linux-kernel-mentees@lists.linuxfoundation.org, cocci On Sat, Aug 22 2020 at 09:07, Julia Lawall wrote: > On Fri, 21 Aug 2020, Joe Perches wrote: >> True enough for a general statement, though the coccinelle >> script Julia provided does not change a single instance of >> for loop expressions with commas. >> >> As far as I can tell, no logic defect is introduced by the >> script at all. > > The script has a rule to ensure that what is changed is part of a top > level statement that has the form e1, e2;. I put that in to avoid > transforming cases where the comma is the body of a macro, but it protects > against for loop headers as well. Right. I went through the lot and did not find something dodgy. Except for two hunks this still applies. Can someone please send a proper patch with changelog/SOB etc. for this? And of course that script really wants to be part of the kernel cocci checks to catch further instances. Thanks, tglx