From: Louis Peens <louis.peens@corigine.com>
To: Dan Carpenter <dan.carpenter@oracle.com>,
Simon Horman <simon.horman@corigine.com>
Cc: Jakub Kicinski <kuba@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Yinjun Zhang <yinjun.zhang@corigine.com>,
oss-drivers@corigine.com, netdev@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH net-next] nfp: flower-ct: check for error in nfp_fl_ct_offload_nft_flow()
Date: Mon, 21 Jun 2021 07:15:08 +0200 [thread overview]
Message-ID: <94d89b59-fe5b-d959-e2f0-9e42ebf73636@corigine.com> (raw)
In-Reply-To: <YM321r7Enw8sGj0X@mwanda>
On 2021/06/19 15:53, Dan Carpenter wrote:
> The nfp_fl_ct_add_flow() function can fail so we need to check for
> failure.
>
> Fixes: 95255017e0a8 ("nfp: flower-ct: add nft flows to nft list")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Ah, of course, thank you.
Reviewed-by: Louis Peens <louis.peens@corigine.com>
> ---
> drivers/net/ethernet/netronome/nfp/flower/conntrack.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/net/ethernet/netronome/nfp/flower/conntrack.c b/drivers/net/ethernet/netronome/nfp/flower/conntrack.c
> index 9ea77bb3b69c..273d529d43c2 100644
> --- a/drivers/net/ethernet/netronome/nfp/flower/conntrack.c
> +++ b/drivers/net/ethernet/netronome/nfp/flower/conntrack.c
> @@ -1067,6 +1067,8 @@ nfp_fl_ct_offload_nft_flow(struct nfp_fl_ct_zone_entry *zt, struct flow_cls_offl
> nfp_ct_map_params);
> if (!ct_map_ent) {
> ct_entry = nfp_fl_ct_add_flow(zt, NULL, flow, true, extack);
> + if (IS_ERR(ct_entry))
> + return PTR_ERR(ct_entry);
> ct_entry->type = CT_TYPE_NFT;
> list_add(&ct_entry->list_node, &zt->nft_flows_list);
> zt->nft_flows_count++;
>
next prev parent reply other threads:[~2021-06-21 5:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-19 13:53 [PATCH net-next] nfp: flower-ct: check for error in nfp_fl_ct_offload_nft_flow() Dan Carpenter
2021-06-21 5:15 ` Louis Peens [this message]
2021-06-21 9:22 ` Simon Horman
2021-06-21 19:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=94d89b59-fe5b-d959-e2f0-9e42ebf73636@corigine.com \
--to=louis.peens@corigine.com \
--cc=dan.carpenter@oracle.com \
--cc=davem@davemloft.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=oss-drivers@corigine.com \
--cc=simon.horman@corigine.com \
--cc=yinjun.zhang@corigine.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).