From: Damien Le Moal <damien.lemoal@opensource.wdc.com>
To: Arnd Bergmann <arnd@arndb.de>,
Christophe Leroy <christophe.leroy@csgroup.eu>,
Lukas Bulwahn <lukas.bulwahn@gmail.com>,
Michael Ellerman <mpe@ellerman.id.au>,
Nicholas Piggin <npiggin@gmail.com>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
"linux-ide@vger.kernel.org" <linux-ide@vger.kernel.org>
Cc: "kernel-janitors@vger.kernel.org"
<kernel-janitors@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] powerpc: select HAVE_PATA_PLATFORM in PPC instead of creating a PPC dependency
Date: Sun, 11 Sep 2022 23:18:40 +0900 [thread overview]
Message-ID: <99d7c533-f19e-a52a-e532-2a07cd78e9b9@opensource.wdc.com> (raw)
In-Reply-To: <c4f3d527-7e70-4077-b40b-129144d79374@www.fastmail.com>
On 2022/09/11 21:41, Arnd Bergmann wrote:
> On Sun, Sep 11, 2022, at 1:54 PM, Damien Le Moal wrote:
>> On 2022/09/09 20:31, Arnd Bergmann wrote:
>>>
>>> config PATA_PLATFORM
>>> - tristate "Generic platform device PATA support"
>>> - depends on EXPERT || PPC || HAVE_PATA_PLATFORM
>>> + tristate "Generic platform device PATA support" if EXPERT || HAVE_PATA_PLATFORM
>>
>> Shouldn't this be:
>>
>> tristate "Generic platform device PATA support" if EXPERT || PPC
>>
>> ?
>>
>> And while at it, it would be nice to add "|| COMPILE_TEST" too.
>
> The idea was that this can be selected by CONFIG_PATA_OF_PLATFORM
> in any configuration that has CONFIG_OF enabled. Since PPC
> has CONFIG_OF enabled unconditionally, there is no need to
> make this option visible separately.
>
> Same for compile-testing: since CONFIG_OF can be enabled on
> any architecture, PATA_OF_PLATFORM is already covered by
> allmodconfig builds anywhere. The separate HAVE_PATA_PLATFORM
> is only needed for machines that want the non-OF pata-platform
> module (sh, m68k-mac, mips-sibyte arm-s3c-simtec).
Got it. Thanks for the details.
>
> Arnd
--
Damien Le Moal
Western Digital Research
prev parent reply other threads:[~2022-09-11 14:18 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-09 9:03 [PATCH v2] powerpc: select HAVE_PATA_PLATFORM in PPC instead of creating a PPC dependency Lukas Bulwahn
2022-09-09 9:03 ` [PATCH] ppc: " Lukas Bulwahn
2022-09-09 9:43 ` Lukas Bulwahn
2022-09-09 11:09 ` [PATCH v2] powerpc: " Arnd Bergmann
2022-09-09 11:13 ` Lukas Bulwahn
2022-09-09 11:19 ` Christophe Leroy
2022-09-09 11:31 ` Arnd Bergmann
2022-09-11 11:54 ` Damien Le Moal
2022-09-11 12:41 ` Arnd Bergmann
2022-09-11 14:18 ` Damien Le Moal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=99d7c533-f19e-a52a-e532-2a07cd78e9b9@opensource.wdc.com \
--to=damien.lemoal@opensource.wdc.com \
--cc=arnd@arndb.de \
--cc=christophe.leroy@csgroup.eu \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=lukas.bulwahn@gmail.com \
--cc=mpe@ellerman.id.au \
--cc=npiggin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).