From mboxrd@z Thu Jan 1 00:00:00 1970 From: Himanshu Madhani Date: Thu, 08 Oct 2020 18:40:33 +0000 Subject: Re: [PATCH] scsi: qla2xxx: fix return of uninitialized value in rval Message-Id: <9AD290EF-AA42-48F4-99F0-2C8FBDB592BA@oracle.com> List-Id: References: <20201008183239.200358-1-colin.king@canonical.com> In-Reply-To: <20201008183239.200358-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Colin King Cc: Nilesh Javali , GR-QLogic-Storage-Upstream , "James E . J . Bottomley" , "Martin K . Petersen" , Pavel Machek , linux-scsi@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org > On Oct 8, 2020, at 1:32 PM, Colin King wrote: > > From: Colin Ian King > > A previous change removed the initialization of rval and there is > now an error where an uninitialized rval is being returned on an > error return path. Fix this by returning -ENODEV. > > Addresses-Coverity: ("Uninitialized scalar variable") > Fixes: b994718760fa ("scsi: qla2xxx: Use constant when it is known") > Signed-off-by: Colin Ian King > --- > drivers/scsi/qla2xxx/qla_nvme.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/scsi/qla2xxx/qla_nvme.c b/drivers/scsi/qla2xxx/qla_nvme.c > index ae47e0eb0311..1f9005125313 100644 > --- a/drivers/scsi/qla2xxx/qla_nvme.c > +++ b/drivers/scsi/qla2xxx/qla_nvme.c > @@ -561,7 +561,7 @@ static int qla_nvme_post_cmd(struct nvme_fc_local_port *lport, > vha = fcport->vha; > > if (!(fcport->nvme_flag & NVME_FLAG_REGISTERED)) > - return rval; > + return -ENODEV; > > if (test_bit(ABORT_ISP_ACTIVE, &vha->dpc_flags) || > (qpair && !qpair->fw_started) || fcport->deleted) > -- > 2.27.0 > Reviewed-by: Himanshu Madhani -- Himanshu Madhani Oracle Linux Engineering