From mboxrd@z Thu Jan 1 00:00:00 1970 From: Markus Elfring Date: Mon, 08 Jun 2020 15:07:33 +0000 Subject: Re: [PATCH] exfat: Fix use after free in exfat_load_upcase_table() Message-Id: <9b9272fb-b265-010b-0696-4c0579abd841@web.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: Dan Carpenter , linux-fsdevel@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, Namjae Jeon , Sungjong Seo , Tetsuhiro Kohada > This code calls brelse(bh) and then dereferences "bh" on the next line > resulting in a possible use after free. There is an unfortunate function call sequence. > The brelse() should just be moved down a line. How do you think about a wording variant like the following? Thus move a call of the function “brelse” one line down. Would you like to omit a word from the patch subject so that a typo will be avoided there? Regards, Markus