From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: jic23@kernel.org, lars@metafoo.de, ardeleanalex@gmail.com,
andy.shevchenko@gmail.com, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH v2] iio: adc128s052: Simplify 'adc128_probe()'
Date: Fri, 27 Aug 2021 18:34:32 +0200 [thread overview]
Message-ID: <9bd1b2a1-1d86-3907-e62b-f1ecc2dc9995@wanadoo.fr> (raw)
In-Reply-To: <20210827073536.GD1931@kadam>
Le 27/08/2021 à 09:35, Dan Carpenter a écrit :
> On Thu, Aug 26, 2021 at 08:28:08PM +0200, Christophe JAILLET wrote:
>> @@ -172,13 +167,23 @@ static int adc128_probe(struct spi_device *spi)
>> ret = regulator_enable(adc->reg);
>> if (ret < 0)
>> return ret;
>> - ret = devm_add_action_or_reset(&spi->dev, adc128_disable_regulator, adc->reg);
>> - if (ret)
>> - return ret;
>>
>> mutex_init(&adc->lock);
>>
>> - return devm_iio_device_register(&spi->dev, indio_dev);
>> + ret = iio_device_register(indio_dev);
>> +
>> + return ret;
>
> Since you're resending anyway then please do:
>
> return iio_device_register(indio_dev);
>
> regards,
> dan carpenter
>
>
Hi Dan,
This v2 should not be taken into account.
I've sent a v3 just after which already implements what you propose.
Other comments on this v3 are welcome.
CJ
prev parent reply other threads:[~2021-08-27 16:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-26 18:28 [PATCH v2] iio: adc128s052: Simplify 'adc128_probe()' Christophe JAILLET
2021-08-26 18:29 ` Christophe JAILLET
2021-08-27 7:35 ` Dan Carpenter
2021-08-27 16:34 ` Christophe JAILLET [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9bd1b2a1-1d86-3907-e62b-f1ecc2dc9995@wanadoo.fr \
--to=christophe.jaillet@wanadoo.fr \
--cc=andy.shevchenko@gmail.com \
--cc=ardeleanalex@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=jic23@kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).