From: "Huang, Ray" <Ray.Huang@amd.com>
To: YueHaibing <yuehaibing@huawei.com>,
"Deucher, Alexander" <Alexander.Deucher@amd.com>,
"Koenig, Christian" <Christian.Koenig@amd.com>,
"Zhou, David(ChunMing)" <David1.Zhou@amd.com>,
"airlied@linux.ie" <airlied@linux.ie>,
"Liu, Shaoyun" <Shaoyun.Liu@amd.com>,
"Francis, David" <David.Francis@amd.com>,
"Xu, Feifei" <Feifei.Xu@amd.com>,
"Gao, Likun" <Likun.Gao@amd.com>
Cc: "amd-gfx@lists.freedesktop.org" <amd-gfx@lists.freedesktop.org>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"kernel-janitors@vger.kernel.org"
<kernel-janitors@vger.kernel.org>
Subject: RE: [PATCH -next] drm/amdgpu: remove set but not used variable 'ring'
Date: Thu, 15 Nov 2018 11:49:12 +0000 [thread overview]
Message-ID: <BY2PR12MB0040A0E1C221A3EBBF270C30ECDC0@BY2PR12MB0040.namprd12.prod.outlook.com> (raw)
In-Reply-To: <1542279133-103893-1-git-send-email-yuehaibing@huawei.com>
> -----Original Message-----
> From: YueHaibing [mailto:yuehaibing@huawei.com]
> Sent: Thursday, November 15, 2018 6:52 PM
> To: Deucher, Alexander <Alexander.Deucher@amd.com>; Koenig, Christian
> <Christian.Koenig@amd.com>; Zhou, David(ChunMing)
> <David1.Zhou@amd.com>; airlied@linux.ie; Liu, Shaoyun
> <Shaoyun.Liu@amd.com>; Francis, David <David.Francis@amd.com>; Huang,
> Ray <Ray.Huang@amd.com>; Xu, Feifei <Feifei.Xu@amd.com>; Gao, Likun
> <Likun.Gao@amd.com>
> Cc: YueHaibing <yuehaibing@huawei.com>; amd-gfx@lists.freedesktop.org;
> dri-devel@lists.freedesktop.org; linux-kernel@vger.kernel.org; kernel-
> janitors@vger.kernel.org
> Subject: [PATCH -next] drm/amdgpu: remove set but not used variable 'ring'
>
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/gpu/drm/amd/amdgpu/psp_v10_0.c: In function
> 'psp_v10_0_ring_stop':
> drivers/gpu/drm/amd/amdgpu/psp_v10_0.c:230:19: warning:
> variable 'ring' set but not used [-Wunused-but-set-variable]
>
> It not used since commit
> 4ef72453311a ("drm/amdgpu: added api for stopping psp ring (v2)")
Thanks, please also remove the similar code in psp_v3_1.
With that updates, patch is Reviewed-by: Huang Rui <ray.huang@amd.com>
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> drivers/gpu/drm/amd/amdgpu/psp_v10_0.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/psp_v10_0.c
> b/drivers/gpu/drm/amd/amdgpu/psp_v10_0.c
> index 295c220..d78b430 100644
> --- a/drivers/gpu/drm/amd/amdgpu/psp_v10_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/psp_v10_0.c
> @@ -240,12 +240,9 @@ static int psp_v10_0_ring_stop(struct psp_context
> *psp,
> enum psp_ring_type ring_type) {
> int ret = 0;
> - struct psp_ring *ring;
> unsigned int psp_ring_reg = 0;
> struct amdgpu_device *adev = psp->adev;
>
> - ring = &psp->km_ring;
> -
> /* Write the ring destroy command to C2PMSG_64 */
> psp_ring_reg = 3 << 16;
> WREG32_SOC15(MP0, 0, mmMP0_SMN_C2PMSG_64, psp_ring_reg);
>
>
>
>
next prev parent reply other threads:[~2018-11-15 11:49 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-15 10:52 [PATCH -next] drm/amdgpu: remove set but not used variable 'ring' YueHaibing
2018-11-15 11:49 ` Huang, Ray [this message]
2018-11-15 11:56 ` YueHaibing
2019-02-20 3:31 ` [PATCH -next] drm/amdgpu: remove set but not used variables 'vm, bo' YueHaibing
2019-02-28 2:43 ` Alex Deucher
2019-06-22 2:56 ` [PATCH -next] drm/amdgpu: remove set but not used variables 'ret' Mao Wenan
2019-06-22 6:02 ` Julia Lawall
2019-06-22 7:20 ` maowenan
2019-06-22 10:43 ` Dan Carpenter
2019-06-22 12:58 ` [PATCH -next v2] drm/amdgpu: return 'ret' in amdgpu_pmu_init Mao Wenan
2019-06-22 13:06 ` Julia Lawall
2019-06-22 13:56 ` maowenan
2019-06-22 14:00 ` Julia Lawall
2019-06-24 3:16 ` maowenan
2019-06-22 18:13 ` Joe Perches
2019-06-24 3:41 ` maowenan
2019-06-24 3:46 ` Joe Perches
2019-06-23 6:00 ` [PATCH -next] drm/amdgpu: remove set but not used variables 'ret' Dan Carpenter
2019-06-23 6:10 ` Julia Lawall
2019-06-24 3:45 ` [PATCH -next v3] drm/amdgpu: return 'ret' immediately if failed in amdgpu_pmu_init Mao Wenan
[not found] ` <20190624034532.135201-1-maowenan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2019-06-24 8:39 ` Dan Carpenter
2019-06-24 9:29 ` maowenan
[not found] ` <4795ba5c-8e41-e1e0-c96a-47fdda3995e3-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2019-06-24 9:48 ` Dan Carpenter
2019-06-24 11:23 ` [PATCH -next v4] " Mao Wenan
[not found] ` <20190624112318.149299-1-maowenan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2019-06-24 17:42 ` Kim, Jonathan
2019-06-26 11:35 ` maowenan
2019-07-10 7:31 ` maowenan
2020-07-02 1:55 ` [PATCH -next] drm/amdgpu: remove set but not used variable 'adev' YueHaibing
2020-07-06 16:06 ` Alex Deucher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BY2PR12MB0040A0E1C221A3EBBF270C30ECDC0@BY2PR12MB0040.namprd12.prod.outlook.com \
--to=ray.huang@amd.com \
--cc=Alexander.Deucher@amd.com \
--cc=Christian.Koenig@amd.com \
--cc=David.Francis@amd.com \
--cc=David1.Zhou@amd.com \
--cc=Feifei.Xu@amd.com \
--cc=Likun.Gao@amd.com \
--cc=Shaoyun.Liu@amd.com \
--cc=airlied@linux.ie \
--cc=amd-gfx@lists.freedesktop.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).